Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RPC support for the efr32 lock app #10232

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

andy31415
Copy link
Contributor

Problem

Lock app does not support RPC (compilation fails):

2021-10-05 15:59:42 INFO    /home/vscode/pigweed/env/cipd/pigweed/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/pigweed/repo/pw_kvs/pw_kvs.entry.cc.o: in function `pw::kvs::internal::Entry::Read(pw::kvs::FlashPartition&, unsigned long, pw::kvs::internal::EntryFormats const&, pw::kvs::internal::Entry*)':
2021-10-05 15:59:42 INFO    out/third_party/connectedhomeip/third_party/pigweed/repo/pw_kvs/entry.cc:54: undefined reference to `pw_Log'
2021-10-05 15:59:42 INFO    /home/vscode/pigweed/env/cipd/pigweed/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/pigweed/repo/pw_kvs/pw_kvs.entry.cc.o: in function `pw::kvs::internal::Entry::VerifyChecksumInFlash() const':
2021-10-05 15:59:42 INFO    out/third_party/connectedhomeip/third_party/pigweed/repo/pw_kvs/entry.cc:214: undefined reference to `pw_Log'
2021-10-05 15:59:42 INFO    /home/vscode/pigweed/env/cipd/pigweed/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/pigweed/repo/pw_kvs/pw_kvs.entry_cache.cc.o: in function `pw::kvs::internal::EntryCache::Find(pw::kvs::FlashPartition&, pw::kvs::internal::Sectors const&, pw::kvs::internal::EntryFormats const&, pw::kvs::Key, pw::kvs::internal::EntryMetadata*) const':
2021-10-05 15:59:42 INFO    out/third_party/connectedhomeip/third_party/pigweed/repo/pw_kvs/entry_cache.cc:96: undefined reference to `pw_Log'
2021-10-05 15:59:42 INFO    /home/vscode/pigweed/env/cipd/pigweed/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: out/third_party/connectedhomeip/third_party/pigweed/repo/pw_kvs/entry_cache.cc:105: undefined reference to `pw_Log'
2021-10-05 15:59:42 INFO    /home/vscode/pigweed/env/cipd/pigweed/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: out/third_party/connectedhomeip/third_party/pigweed/repo/pw_kvs/entry_cache.cc:112: undefined reference to `pw_Log'
2021-10-05 15:59:42 INFO    /home/vscode/pigweed/env/cipd/pigweed/bin/../lib/gcc/arm-none-eabi/10.2.1/../../../../arm-none-eabi/bin/ld: obj/third_party/connectedhomeip/third_party/pigweed/repo/pw_kvs/pw_kvs.entry_cache.cc.o:out/third_party/connectedhomeip/third_party/pigweed/repo/pw_kvs/entry_cache.cc:159: more undefined references to `pw_Log' follow
2021-10-05 15:59:42 INFO    collect2: error: ld returned 1 exit status
2021-10-05 15:59:42 INFO    ninja: build stopped: subcommand failed.

Change overview

Remove -rpc variant from efr32-lock

Testing

unit test shows variant was removed

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Oct 5, 2021
@andy31415
Copy link
Contributor Author

Hotfix: github CI is broken and cannot validate this in general. CI that builds -rpc variant is in cloudbuild.

@andy31415 andy31415 merged commit fbebdb1 into project-chip:master Oct 5, 2021
@andy31415 andy31415 deleted the no_rpc_for_lock branch October 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review scripts vscode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants