Restyle Normalized generation of DecodableType cluster objects.
#10176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![restyled-io[bot]](https://avatars.githubusercontent.com/in/5851?s=60&v=4){kind=small}
Today for a struct definition in schema, a `Type` cluster object definition is minimally generated, while a `DecodableType` object definition is only generated if the struct contains a list. The presence of such embedded lists requires the use of the `DecodableType`, which in turn contains a DataModel::DecodableList instead of a Span-backed DataModel::List to permit in-place traversal of the list. However, this creates inconsistency since some structs only come with a single 'Type' definition while others come with both. This PR normalizes it such that both `Type` and `DecodableType` are emitted, with the latter just an alias to 'Type' if it doesn't contain a list. This makes it easier for developers to always rely on using the `DecodableType` for decoding data, and the `Type` type for encoding. This also simplifies the ZAPT template files as well, and sets the stage for some future simplifications as well for supporting these objects for attributes and commands. Bundled some other minimal fixes as well in this PR. a Please enter the commit message for your changes. Lines starting
tleacmcsa
added a commit
to tleacmcsa/connectedhomeip
that referenced
this pull request
Jul 30, 2024
Was supposed to be a list of AccessRestrictionEntryStructs, not AccessRestrictionStructs. Spec text updated in PR project-chip#10176 Since AccessRestrictionEntryStruct is fabric-sensitive, we use CommissioningAccessRestrictionEntryStruct.
andy31415
pushed a commit
that referenced
this pull request
Jul 31, 2024
Was supposed to be a list of AccessRestrictionEntryStructs, not AccessRestrictionStructs. Spec text updated in PR #10176 Since AccessRestrictionEntryStruct is fabric-sensitive, we use CommissioningAccessRestrictionEntryStruct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #10175 with additional commits that automatically address
incorrect style, created by Restyled.
Please review accordingly.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.