-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verhoeff code is not using tables as const causing unnecessary RAM use #9564
Labels
Comments
michalbudzon-q
added a commit
to michalbudzon-q/connectedhomeip
that referenced
this issue
Nov 12, 2021
michalbudzon-q
added a commit
to michalbudzon-q/connectedhomeip
that referenced
this issue
Nov 12, 2021
michalbudzon-q
added a commit
to michalbudzon-q/connectedhomeip
that referenced
this issue
Nov 12, 2021
michalbudzon-q
added a commit
to michalbudzon-q/connectedhomeip
that referenced
this issue
Nov 17, 2021
andy31415
pushed a commit
that referenced
this issue
Nov 29, 2021
Fixed in #11726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
The Verhoeff calculations use fixed tables
sMultiplyTable
andsPermTable
which are currently not defined as const tables.This adds 110 bytes RAM for example in the Verhoeff10 case.
The function using the permutation table in the Verfhoeff part also doesn't specify 'const' for the table pointer.
Verhoeff::Permute(int val, uint8_t * permTable, int permTableLen, uint64_t iterCount)
https://github.com/project-chip/connectedhomeip/tree/master/src/lib/support/verhoeff
connectedhomeip/src/lib/support/verhoeff/Verhoeff10.cpp
Line 33 in 741ab0a
Proposed Solution
The text was updated successfully, but these errors were encountered: