Various Builder ::EndOf* functions should probably return mError, not *this

[bzbarsky-apple]

Problem

An example. ReadRequest::Builder & ReadRequest::Builder::EndOfReadRequest(). So consumers have to use it like so:

        request.EndOfReadRequest();
        SuccessOrExit(err = request.GetError());

But if we're at the end, what's the point of returning this? We don't in fact want to have any more calls adding more things to our TLV at this point!

Proposed Solution

If EndOfReadRequest returned mError, this would look like this:

SuccessOrExit(err = request.EndOfReadRequest());

which seems a lot more natural and harder to misuse.

@yunhanw-google

[yunhanw-google]

Yep, agree, would update this next week, thanks

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.