Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Q on operationalstate CountdownTime #34421

Open
tcarmelveilleux opened this issue Jul 19, 2024 · 0 comments
Open

Implement Q on operationalstate CountdownTime #34421

tcarmelveilleux opened this issue Jul 19, 2024 · 0 comments
Assignees
@tcarmelveilleux
Labels
TCR

Comments

@tcarmelveilleux
Copy link
Contributor

Actually implement reporting on CountdownTime whenever edges arise, and at most every 10s when requested by delegate.
@tcarmelveilleux tcarmelveilleux self-assigned this Jul 19, 2024
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jul 19, 2024
@tcarmelveilleux
Add Q quality to OperationalState CountdownTIme
72616a6 
- Update operational state cluster server to report countdown time at edges.
- Add a way for cluster delegate to request an update of time.

Issue project-chip#34421

Testing done:

- Existing tests still pass
- Will add cert test when the text is finalized (week of July 22)
@tcarmelveilleux tcarmelveilleux mentioned this issue Jul 19, 2024
Merged
mergify bot pushed a commit that referenced this issue Jul 30, 2024
@tcarmelveilleux @restyled-commits
Add Q quality to OperationalState CountdownTime (#34422)
8060d45 
* Fix post-review comments on Q quality utils from #34266

- PR #34266 had post review comments
  See: #34266 (review)
- Fix 0->0 case
- Introduce `Timestamp` more places where it makes sense
- Simplify some code lines

Fixes #34334

Testing done:

- Added unit test for 0->0
- Tests still pass

* Restyled by clang-format

* Address review comments

* Restyled by clang-format

* Add Q quality to OperationalState CountdownTIme

- Update operational state cluster server to report countdown time at edges.
- Add a way for cluster delegate to request an update of time.

Issue #34421

Testing done:

- Existing tests still pass
- Will add cert test when the text is finalized (week of July 22)

* Restyled by clang-format

* Address review comments

* Address review comments

* Update src/app/clusters/operational-state-server/operational-state-server.cpp

* Fix several Opstate test cases

* Restyled by autopep8

* Fix minor grammar typo

* Restyled by autopep8

* Fix TC-OPSTATE-2.2

---------

Co-authored-by: Restyled.io <[email protected]>
j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this issue Jul 31, 2024
@tcarmelveilleux @restyled-commits @j-ororke
Add Q quality to OperationalState CountdownTime (project-chip#34422)
e8ade59 
* Fix post-review comments on Q quality utils from project-chip#34266

- PR project-chip#34266 had post review comments
  See: project-chip#34266 (review)
- Fix 0->0 case
- Introduce `Timestamp` more places where it makes sense
- Simplify some code lines

Fixes project-chip#34334

Testing done:

- Added unit test for 0->0
- Tests still pass

* Restyled by clang-format

* Address review comments

* Restyled by clang-format

* Add Q quality to OperationalState CountdownTIme

- Update operational state cluster server to report countdown time at edges.
- Add a way for cluster delegate to request an update of time.

Issue project-chip#34421

Testing done:

- Existing tests still pass
- Will add cert test when the text is finalized (week of July 22)

* Restyled by clang-format

* Address review comments

* Address review comments

* Update src/app/clusters/operational-state-server/operational-state-server.cpp

* Fix several Opstate test cases

* Restyled by autopep8

* Fix minor grammar typo

* Restyled by autopep8

* Fix TC-OPSTATE-2.2

---------

Co-authored-by: Restyled.io <[email protected]>
erwinpan1 pushed a commit to erwinpan1/connectedhomeip that referenced this issue Nov 11, 2024
@tcarmelveilleux @restyled-commits @erwinpan1
Add Q quality to OperationalState CountdownTime (project-chip#34422)
80de34e 
* Fix post-review comments on Q quality utils from project-chip#34266

- PR project-chip#34266 had post review comments
  See: project-chip#34266 (review)
- Fix 0->0 case
- Introduce `Timestamp` more places where it makes sense
- Simplify some code lines

Fixes project-chip#34334

Testing done:

- Added unit test for 0->0
- Tests still pass

* Restyled by clang-format

* Address review comments

* Restyled by clang-format

* Add Q quality to OperationalState CountdownTIme

- Update operational state cluster server to report countdown time at edges.
- Add a way for cluster delegate to request an update of time.

Issue project-chip#34421

Testing done:

- Existing tests still pass
- Will add cert test when the text is finalized (week of July 22)

* Restyled by clang-format

* Address review comments

* Address review comments

* Update src/app/clusters/operational-state-server/operational-state-server.cpp

* Fix several Opstate test cases

* Restyled by autopep8

* Fix minor grammar typo

* Restyled by autopep8

* Fix TC-OPSTATE-2.2

---------

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcarmelveilleux tcarmelveilleux

Labels
TCR
Projects
[Feature] Operational State
Status: Todo
[TCR] 1.3 TCRs
Status: Todo
[TCR][Fall 2024] Add Q quality to OperationalState CountdownTime
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tcarmelveilleux