Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.3] Gaps in TV clusters - cont #31320

Closed
chrisdecenzo opened this issue Jan 9, 2024 · 1 comment
Closed

[1.3] Gaps in TV clusters - cont #31320

chrisdecenzo opened this issue Jan 9, 2024 · 1 comment
Assignees
@lazarkov @chrisdecenzo
Labels
bug Something isn't working needs triage spec Mismatch between spec and implementation

Comments

@chrisdecenzo
Copy link
Contributor

chrisdecenzo commented Jan 9, 2024 •
edited
Loading

Reproduction steps

Here is a list of updates needed for the tv example apps in order to use them for showcasing 1.3 functionality:

  1. tv-app: ensure all the new TV 1.3 features are enabled
  2. wrap up message cluster PR (see Messages Cluster XML #30254)
  3. tv-app: add message as a server cluster on ep2.
  4. tv-casting-app: add message as a client cluster on ep2.
  5. Bump revision number of updated TV clusters from 1 to 2: AccountLogin, Channel, MediaPlayback, TargetNavigator - see 30261 , 30410 and 30411
  6. Add missing OTT type to ChannelTypeEnum in Channel cluster.
  7. Enable 3 new feature flags for ContentControl cluster (bits 5, 6, 7).

NOTE: This commit by @cecille seems to have accidentally removed the Message cluster events:
9c0cd9e#diff-cc2349c86fdf91ea42e6eaf7253544065f6adefd863ab6f6a16e0b63f8ca8743

Bug prevalence

always

GitHub hash of the SDK that was being used

master

Platform

core

Platform Version(s)

No response

Type

Common Cluster Logic

Anything else?

No response
@chrisdecenzo chrisdecenzo added bug Something isn't working needs triage labels Jan 9, 2024
@chrisdecenzo chrisdecenzo mentioned this issue Jan 9, 2024
Closed
@bzbarsky-apple bzbarsky-apple added the spec Mismatch between spec and implementation label Jan 9, 2024
@chrisdecenzo chrisdecenzo mentioned this issue Jan 19, 2024
Merged
@lazarkov
Copy link
Contributor

#30254 under point number 2 continued here: #31656

@lazarkov lazarkov mentioned this issue Jan 25, 2024
Merged
lazarkov added a commit that referenced this issue Jan 26, 2024
@lazarkov
TV Matter Media: Updated existing cluster to resolve the issue #31320 (…
c7383a0 
…#31676)

* Update XML & Zap file per reported issues

* Run ZAP tool

* apply manual patch
This was referenced Feb 2, 2024
Merged
Merged
lazarkov added a commit that referenced this issue Feb 3, 2024
@lazarkov
TV Matter Media: Updated existing cluster to resolve the issue #31320 (…
1f3675c 
…#31865)

* Update TV & TV Casting App ZAPs

* Update Matter files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lazarkov lazarkov

@chrisdecenzo chrisdecenzo

Labels
bug Something isn't working needs triage spec Mismatch between spec and implementation
Projects
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lazarkov @chrisdecenzo @bzbarsky-apple