Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [TC_TSTAT_2_2] Step 10a has the wrong PICS #29183

Closed
mhazley opened this issue Sep 12, 2023 · 2 comments
Closed

[BUG] [TC_TSTAT_2_2] Step 10a has the wrong PICS #29183

mhazley opened this issue Sep 12, 2023 · 2 comments
Labels
bug Something isn't working needs triage sve yaml Missing features or bugs in the YAML test harness

Comments

@mhazley
Copy link
Contributor

mhazley commented Sep 12, 2023

Reproduction steps

Test plan for step 10a reads:

Set MinHeatSetpointLimit and MaxHeatSetpointLimit back to reasonable values. (f.e. 700 & 3000 == 7°C & 30°C)

MinHeatSetpointLimit PICS is TSTAT.S.A0015, MaxHeatSetpointLimit PICS is TSTAT.S.A0016, and the HEAT feature PICS is TSTAT.S.F00.

The versions of the test steps are below:

    - label:
          "Step 10a: Writes (sets back) default value of MinHeatSetpointLimit"
      command: "writeAttribute"
      attribute: "MinHeatSetpointLimit"
      PICS: TSTAT.S.F01 && TSTAT.S.A0015 && TSTAT.S.A0003
      arguments:
          value: AbsMinHeatSetpointLimitValue

    - label:
          "Step 10a: Writes (sets back) default value of MinHeatSetpointLimit"
      command: "writeAttribute"
      attribute: "MinHeatSetpointLimit"
      PICS: TSTAT.S.F01 && TSTAT.S.A0015 && !TSTAT.S.A0003
      arguments:
          value: 700

    - label: "Step 10a: Writes (sets back)default value of MaxHeatSetpointLimit"
      command: "writeAttribute"
      attribute: "MaxHeatSetpointLimit"
      PICS: TSTAT.S.F01 && TSTAT.S.A0016 && !TSTAT.S.F05 && TSTAT.S.A0004
      arguments:
          value: AbsMaxHeatSetpointLimitValue

    - label: "Step 10a: Writes (sets back)default value of MaxHeatSetpointLimit"
      command: "writeAttribute"
      attribute: "MaxHeatSetpointLimit"
      PICS: TSTAT.S.F01 && TSTAT.S.A0016 && !TSTAT.S.F05 && !TSTAT.S.A0004
      arguments:
          value: 3000

    - label:
          "Step 10a: Writes MaxHeatSetpointLimit That meets the deadband of 2.5C"
      command: "writeAttribute"
      attribute: "MaxHeatSetpointLimit"
      PICS: TSTAT.S.F01 && TSTAT.S.A0016 && TSTAT.S.F05
      arguments:
          value: 2950

As you can see, all the tests have a PICS of PICS: TSTAT.S.F01 which is the COOL feature.

This means that if the COOL feature is not enabled, these values never get reset and the test case fails in a later step that relies on this.

Bug prevalence

Always when COOL feature is disabled

GitHub hash of the SDK that was being used

ToT

Platform

ameba, raspi

Platform Version(s)

ToT

Anything else?

No response
@mhazley mhazley added bug Something isn't working needs triage yaml Missing features or bugs in the YAML test harness labels Sep 12, 2023
@bzbarsky-apple
Copy link
Contributor

@manjunath-grl @cjandhyala

@manjunath-grl manjunath-grl mentioned this issue Sep 13, 2023
Merged
manjunath-grl added a commit to manjunath-grl/connectedhomeip that referenced this issue Sep 13, 2023
@manjunath-grl
Fixes issue: project-chip#29182, project-chip#29183
5752dc4
manjunath-grl added a commit to manjunath-grl/connectedhomeip that referenced this issue Sep 13, 2023
@manjunath-grl
Fixes issue: project-chip#29182, project-chip#29183
c87ad88
manjunath-grl added a commit to manjunath-grl/connectedhomeip that referenced this issue Sep 14, 2023
@manjunath-grl
Fixes issue: project-chip#29182, project-chip#29183
fde53a8
mergify bot pushed a commit that referenced this issue Sep 14, 2023
@manjunath-grl @restyled-commits
Fix script issues Sep 12 (#29179)
52caffd 
* Semi-automated --> Automated tests:
TC-ACL-2.5
TC-ACL-2.6
TC-MEDIAPLAYBACK-6.3
Manual --> Automated:
TC-TCCM-3.1
TC-TCCM-3.2
TC-TCTL-2.1
TC-TCTL-2.2
TC-TCTL-2.3

* Fixes issue:
634, 636, 637, 639, 640, 641, 642, 645, 646
Modified tests:
TC_CADMIN_1_26
TC_DA_1_8
TC_DGGEN_2_1
TC_DGETH_2_1
TC_DGWIFI_3_2_Simulated
TC_DISHALM_3_1
TC_DISHALM_3_2
TC_DISHALM_3_3
TC_DISHALM_3_4
TC_DISHALM_3_5
TC_DISHALM_3_6
TC_GRPKEY_2_1
TC_GRPKEY_2_2
TC_LTIME_3_1
TC_MOD_3_3
TC_MOD_3_4
TC_SC_4_2
TC_SC_4_3
TC_SC_4_4
TC_SC_4_6
TC_TCCM_3_2
TC_WNCV_3_1
TC_WNCV_3_2

* Fixes issue: 645, 643
Modified tests:
TC-ACL-2.10
TC-GRPKEY-2.2
Manual tests:
TC-BIND-2.1
TC-CNET-4.10
TC-MOD-1.3
TC-SWTCH-2.2

* Restyled by whitespace

* Fixed the MOD-3.4 and TCTL-2.3 CI failures.

* Fixed MOD-3.4 CI failure.

* Fix Darwin failure for TCTL-2.3

* Modifed test as per comments:
TC-DGETH-2.1
TC-DGGEN-2.1
TC-TCCM-3.1
TC-TCTL-2.1
TC-GRPKEY-2.1

* Restyled by prettier-yaml

* Removed wait step as it is not in test-plan.

* Fixes issue: #29182, #29183

* Fix issue: 647

* Fix CI failures for ACL-2.5, 2.6 testcases

---------

Co-authored-by: Restyled.io <[email protected]>
@manjunath-grl
Copy link
Contributor

@mhazley Can you please confirm it is fixed in PR 29179 and close the ticket.

@mhazley mhazley closed this as completed Sep 26, 2023
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@manjunath-grl @restyled-commits @HunsupJung
Fix script issues Sep 12 (project-chip#29179)
bb32df1 
* Semi-automated --> Automated tests:
TC-ACL-2.5
TC-ACL-2.6
TC-MEDIAPLAYBACK-6.3
Manual --> Automated:
TC-TCCM-3.1
TC-TCCM-3.2
TC-TCTL-2.1
TC-TCTL-2.2
TC-TCTL-2.3

* Fixes issue:
634, 636, 637, 639, 640, 641, 642, 645, 646
Modified tests:
TC_CADMIN_1_26
TC_DA_1_8
TC_DGGEN_2_1
TC_DGETH_2_1
TC_DGWIFI_3_2_Simulated
TC_DISHALM_3_1
TC_DISHALM_3_2
TC_DISHALM_3_3
TC_DISHALM_3_4
TC_DISHALM_3_5
TC_DISHALM_3_6
TC_GRPKEY_2_1
TC_GRPKEY_2_2
TC_LTIME_3_1
TC_MOD_3_3
TC_MOD_3_4
TC_SC_4_2
TC_SC_4_3
TC_SC_4_4
TC_SC_4_6
TC_TCCM_3_2
TC_WNCV_3_1
TC_WNCV_3_2

* Fixes issue: 645, 643
Modified tests:
TC-ACL-2.10
TC-GRPKEY-2.2
Manual tests:
TC-BIND-2.1
TC-CNET-4.10
TC-MOD-1.3
TC-SWTCH-2.2

* Restyled by whitespace

* Fixed the MOD-3.4 and TCTL-2.3 CI failures.

* Fixed MOD-3.4 CI failure.

* Fix Darwin failure for TCTL-2.3

* Modifed test as per comments:
TC-DGETH-2.1
TC-DGGEN-2.1
TC-TCCM-3.1
TC-TCTL-2.1
TC-GRPKEY-2.1

* Restyled by prettier-yaml

* Removed wait step as it is not in test-plan.

* Fixes issue: project-chip#29182, project-chip#29183

* Fix issue: 647

* Fix CI failures for ACL-2.5, 2.6 testcases

---------

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage sve yaml Missing features or bugs in the YAML test harness
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mhazley @bzbarsky-apple @manjunath-grl