Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XML] Align chip-types.xml with the spec while making a nod towards the data model number allocation #28976

Closed
robszewczyk opened this issue Aug 31, 2023 · 0 comments · Fixed by #28978
Closed

[XML] Align chip-types.xml with the spec while making a nod towards the data model number allocation #28976

robszewczyk opened this issue Aug 31, 2023 · 0 comments · Fixed by #28978
Assignees
@robszewczyk
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)

Comments

@robszewczyk
Copy link
Contributor

IDs for data types are not used in Matter over the wire, so there is no impact to interop, and the SDK can readily be changed. Align the https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/chip-types.xml with the Matter spec in line with changes in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7054
@robszewczyk robszewczyk added the Spec XML align SDK XML does not match the spec (including naming, etc) label Aug 31, 2023
@robszewczyk robszewczyk self-assigned this Aug 31, 2023
@robszewczyk robszewczyk mentioned this issue Aug 31, 2023
Merged
robszewczyk added a commit to robszewczyk/connectedhomeip that referenced this issue Aug 31, 2023
@robszewczyk
Aligned chip-types.xml with the latest Matter spec
53769d4 
* reordered the XML to use the same order as the spec; this should make
  maintenance a bit more sane
* renumbered types to avoid duplication and conflicts and to align with
  the spec

Fixes project-chip#28976
@mergify mergify bot closed this as completed in #28978 Sep 5, 2023
mergify bot pushed a commit that referenced this issue Sep 5, 2023
@robszewczyk
Aligned chip-types.xml with the latest Matter spec (#28978)
eb019b0 
* Aligned chip-types.xml with the latest Matter spec

* reordered the XML to use the same order as the spec; this should make
  maintenance a bit more sane
* renumbered types to avoid duplication and conflicts and to align with
  the spec

Fixes #28976

* Regen ZAP

* Reflect the type changes in the Python codegen per code review comment

* Add XSD validation for unique IDs

* Add a unique constraint on the `id` element in `<type/>` sequence
* Add chip-types.xml to the validator script
abpoth pushed a commit to abpoth/connectedhomeip that referenced this issue Sep 12, 2023
@robszewczyk @abpoth
Aligned chip-types.xml with the latest Matter spec (project-chip#28978)
10ba6b0 
* Aligned chip-types.xml with the latest Matter spec

* reordered the XML to use the same order as the spec; this should make
  maintenance a bit more sane
* renumbered types to avoid duplication and conflicts and to align with
  the spec

Fixes project-chip#28976

* Regen ZAP

* Reflect the type changes in the Python codegen per code review comment

* Add XSD validation for unique IDs

* Add a unique constraint on the `id` element in `<type/>` sequence
* Add chip-types.xml to the validator script
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@robszewczyk @HunsupJung
Aligned chip-types.xml with the latest Matter spec (project-chip#28978)
e0078bc 
* Aligned chip-types.xml with the latest Matter spec

* reordered the XML to use the same order as the spec; this should make
  maintenance a bit more sane
* renumbered types to avoid duplication and conflicts and to align with
  the spec

Fixes project-chip#28976

* Regen ZAP

* Reflect the type changes in the Python codegen per code review comment

* Add XSD validation for unique IDs

* Add a unique constraint on the `id` element in `<type/>` sequence
* Add chip-types.xml to the validator script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robszewczyk robszewczyk

Labels
Spec XML align SDK XML does not match the spec (including naming, etc)
Projects
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aligned chip-types.xml with the latest Matter spec robszewczyk/connectedhomeip
1 participant
@robszewczyk