Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CERT-TEST-FAILURE]- TC-ACFREMON-1.1 - Test failed #28197

Closed
Survensa opened this issue Jul 24, 2023 · 1 comment · Fixed by #29074
Closed

[CERT-TEST-FAILURE]- TC-ACFREMON-1.1 - Test failed #28197

Survensa opened this issue Jul 24, 2023 · 1 comment · Fixed by #29074
Assignees
@cliffamzn
Labels
bug Something isn't working cert blocker needs triage
Milestone
1.2

Comments

@Survensa
Copy link

Survensa commented Jul 24, 2023 •
edited
Loading

Feature Area

Other

Test Case

TC-ACFREMON-1.1

Reproduction steps

  1. Bring up the DUT with all-cluster-app.
  2. Pair the DUT using chip-tool through "onnetwork" transport.
  3. Run the command ./chip-tool activatedcarbonfiltermonitoring read feature-map 1 1

Expected Outcome:

[1690181499.378839][8062:8064] CHIP:DMG: }
[1690181499.379113][8062:8064] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0071 Attribute 0x0000_FFFC DataVersion: 1402797121
[1690181499.379203][8062:8064] CHIP:TOO: FeatureMap: 7
[1690181499.379409][8062:8064] CHIP:EM: <<< [E:11917i S:34360 M:35635505 (Ack:251547236)] (S) Msg TX to 1:0000000000000001 [5C90] --- Type 0000:10 (SecureChannel:StandaloneAck)

Actual Outcome:

[1690181499.378839][8062:8064] CHIP:DMG: }
[1690181499.379113][8062:8064] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0071 Attribute 0x0000_FFFC DataVersion: 1402797121
[1690181499.379203][8062:8064] CHIP:TOO: FeatureMap: 3
[1690181499.379409][8062:8064] CHIP:EM: <<< [E:11917i S:34360 M:35635505 (Ack:251547236)] (S) Msg TX to 1:0000000000000001 [5C90] --- Type 0000:10 (SecureChannel:StandaloneAck)

Bug prevalence

Whenever I try to read FeatureMap.

GitHub hash of the SDK that was being used

c1ec2d7

Platform

raspi

Anything else?

As per the Replacement Product List feature implementation, the FeatureMap attribute value should be 7. But currently getting FeatureMap value as 3 in SDK.
@Survensa Survensa added bug Something isn't working cert blocker needs triage labels Jul 24, 2023
@github-project-automation github-project-automation bot moved this to Open Cert Blockers in [Certification] Blockers Jul 24, 2023
@cjandhyala cjandhyala added this to the 1.2 milestone Aug 7, 2023
@andy31415
Copy link
Contributor

@cliffamzn Could you take a look regarding feature map flags here?

cliffamzn added a commit to cliffamzn/connectedhomeip that referenced this issue Sep 5, 2023
@cliffamzn
Fixing feature map for resource monitoring cluster
2621751 
The replacement product list feature bitmask was set to 0x3 when it
should have been set to 0x4. Fixing it here.

Verified by looking reading the feature map in the all clusters app and
the resource monitoring app:

```
> hepafiltermonitoring read feature-map 1 1
...
[1693934613437] [9078:18462448] [DMG]   AttributeReportIBs =
[1693934613437] [9078:18462448] [DMG]   [
[1693934613437] [9078:18462448] [DMG]           AttributeReportIB =
[1693934613437] [9078:18462448] [DMG]           {
[1693934613437] [9078:18462448] [DMG]                   AttributeDataIB =
[1693934613437] [9078:18462448] [DMG]                   {
[1693934613437] [9078:18462448] [DMG]                           DataVersion = 0x443616af,
[1693934613437] [9078:18462448] [DMG]                           AttributePathIB =
[1693934613437] [9078:18462448] [DMG]                           {
[1693934613437] [9078:18462448] [DMG]                                   Endpoint = 0x1,
[1693934613437] [9078:18462448] [DMG]                                   Cluster = 0x72,
[1693934613437] [9078:18462448] [DMG]                                   Attribute = 0x0000_FFFC,
[1693934613437] [9078:18462448] [DMG]                           }
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]                           Data = 7,
[1693934613437] [9078:18462448] [DMG]                   },
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]           },
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]   ],
```

This fixes project-chip#28197 and project-chip#28198
@cliffamzn cliffamzn mentioned this issue Sep 5, 2023
Merged
@mergify mergify bot closed this as completed in #29074 Sep 6, 2023
mergify bot pushed a commit that referenced this issue Sep 6, 2023
@cliffamzn
Fixing feature map for resource monitoring cluster (#29074)
6b708ab 
* Fixing feature map for resource monitoring cluster

The replacement product list feature bitmask was set to 0x3 when it
should have been set to 0x4. Fixing it here.

Verified by looking reading the feature map in the all clusters app and
the resource monitoring app:

```
> hepafiltermonitoring read feature-map 1 1
...
[1693934613437] [9078:18462448] [DMG]   AttributeReportIBs =
[1693934613437] [9078:18462448] [DMG]   [
[1693934613437] [9078:18462448] [DMG]           AttributeReportIB =
[1693934613437] [9078:18462448] [DMG]           {
[1693934613437] [9078:18462448] [DMG]                   AttributeDataIB =
[1693934613437] [9078:18462448] [DMG]                   {
[1693934613437] [9078:18462448] [DMG]                           DataVersion = 0x443616af,
[1693934613437] [9078:18462448] [DMG]                           AttributePathIB =
[1693934613437] [9078:18462448] [DMG]                           {
[1693934613437] [9078:18462448] [DMG]                                   Endpoint = 0x1,
[1693934613437] [9078:18462448] [DMG]                                   Cluster = 0x72,
[1693934613437] [9078:18462448] [DMG]                                   Attribute = 0x0000_FFFC,
[1693934613437] [9078:18462448] [DMG]                           }
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]                           Data = 7,
[1693934613437] [9078:18462448] [DMG]                   },
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]           },
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]   ],
```

This fixes #28197 and #28198

* Updating and adding feature flag tests
@github-project-automation github-project-automation bot moved this from Open Cert Blockers to Complete in [Certification] Blockers Sep 6, 2023
abpoth pushed a commit to abpoth/connectedhomeip that referenced this issue Sep 12, 2023
@cliffamzn @abpoth
Fixing feature map for resource monitoring cluster (project-chip#29074)
0acc421 
* Fixing feature map for resource monitoring cluster

The replacement product list feature bitmask was set to 0x3 when it
should have been set to 0x4. Fixing it here.

Verified by looking reading the feature map in the all clusters app and
the resource monitoring app:

```
> hepafiltermonitoring read feature-map 1 1
...
[1693934613437] [9078:18462448] [DMG]   AttributeReportIBs =
[1693934613437] [9078:18462448] [DMG]   [
[1693934613437] [9078:18462448] [DMG]           AttributeReportIB =
[1693934613437] [9078:18462448] [DMG]           {
[1693934613437] [9078:18462448] [DMG]                   AttributeDataIB =
[1693934613437] [9078:18462448] [DMG]                   {
[1693934613437] [9078:18462448] [DMG]                           DataVersion = 0x443616af,
[1693934613437] [9078:18462448] [DMG]                           AttributePathIB =
[1693934613437] [9078:18462448] [DMG]                           {
[1693934613437] [9078:18462448] [DMG]                                   Endpoint = 0x1,
[1693934613437] [9078:18462448] [DMG]                                   Cluster = 0x72,
[1693934613437] [9078:18462448] [DMG]                                   Attribute = 0x0000_FFFC,
[1693934613437] [9078:18462448] [DMG]                           }
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]                           Data = 7,
[1693934613437] [9078:18462448] [DMG]                   },
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]           },
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]   ],
```

This fixes project-chip#28197 and project-chip#28198

* Updating and adding feature flag tests
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@cliffamzn @HunsupJung
Fixing feature map for resource monitoring cluster (project-chip#29074)
e16551d 
* Fixing feature map for resource monitoring cluster

The replacement product list feature bitmask was set to 0x3 when it
should have been set to 0x4. Fixing it here.

Verified by looking reading the feature map in the all clusters app and
the resource monitoring app:

```
> hepafiltermonitoring read feature-map 1 1
...
[1693934613437] [9078:18462448] [DMG]   AttributeReportIBs =
[1693934613437] [9078:18462448] [DMG]   [
[1693934613437] [9078:18462448] [DMG]           AttributeReportIB =
[1693934613437] [9078:18462448] [DMG]           {
[1693934613437] [9078:18462448] [DMG]                   AttributeDataIB =
[1693934613437] [9078:18462448] [DMG]                   {
[1693934613437] [9078:18462448] [DMG]                           DataVersion = 0x443616af,
[1693934613437] [9078:18462448] [DMG]                           AttributePathIB =
[1693934613437] [9078:18462448] [DMG]                           {
[1693934613437] [9078:18462448] [DMG]                                   Endpoint = 0x1,
[1693934613437] [9078:18462448] [DMG]                                   Cluster = 0x72,
[1693934613437] [9078:18462448] [DMG]                                   Attribute = 0x0000_FFFC,
[1693934613437] [9078:18462448] [DMG]                           }
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]                           Data = 7,
[1693934613437] [9078:18462448] [DMG]                   },
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]           },
[1693934613437] [9078:18462448] [DMG]
[1693934613437] [9078:18462448] [DMG]   ],
```

This fixes project-chip#28197 and project-chip#28198

* Updating and adding feature flag tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cliffamzn cliffamzn

Labels
bug Something isn't working cert blocker needs triage
Projects
[Certification] Blockers
Archived in project
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Fixing feature map for resource monitoring cluster cliffamzn/connectedhomeip
4 participants
@andy31415 @cjandhyala @Survensa @cliffamzn