Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-MOD-1.1]ModeSelect cluster -- ClusterRevision value missmatch #26445

Closed
Survensa opened this issue May 9, 2023 · 5 comments · Fixed by #29140
Closed

[TC-MOD-1.1]ModeSelect cluster -- ClusterRevision value missmatch #26445

Survensa opened this issue May 9, 2023 · 5 comments · Fixed by #29140
Assignees
Labels
app-clusters Application cluster work mode select Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation v1.2
Milestone

Comments

@Survensa
Copy link

Survensa commented May 9, 2023

Problem
As per Spec and test plan, cluster revision value should be 2 but currently getting cluster revision value as 1 in SDK .

Expected behavior: ClusterRevision value as 2

Actual behavior : ClusterRevision value as 1

Steps to reproduce
./chip-tool modeselect read cluster-revision 1 1

System configuration
Chip-tool - RPI-4, 8GB RAM
DUT - RPI - RPI-4, 8GB RAM
Platform : Onnetwork
Commit-ID:6c0c5ea6d2b8f38c6b36b83195b6ee55384bb599
Dut application: all-clusters-app

Test-Plan Reference:-
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/modeselect.adoc

Spec Reference:-
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/ModeSelect.adoc

Log
TC-MOD-1.1.txt

@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation app-clusters Application cluster work labels May 9, 2023
@bzbarsky-apple
Copy link
Contributor

The SDK does not yet implement revision 2 of the cluster. This is not just about bumping the revision number; support is also needed for ChangeToModeWithStatus, the EXT feature, etc.

@rbultman
Copy link
Contributor

The mode select cluster has almost completely reverted back to its original state prior to the additions being moved into the modebase cluster. The revision is still 2, however, but the only substantive change made was to remove the nullable quality from MfgCode. Not sure how that affects your comment @bzbarsky-apple.

@bzbarsky-apple
Copy link
Contributor

SDK implements revision 2, since it had MfgCode non-nullable to start with. We should bump the revision in the SDK...

@andy31415 andy31415 assigned andy31415 and unassigned andy31415 Aug 29, 2023
@andy31415 andy31415 self-assigned this Aug 29, 2023
@andy31415
Copy link
Contributor

Need just a version bump, assigning to myself (expecting just a zap file change)

@bzbarsky-apple
Copy link
Contributor

(expecting just a zap file change)

The XML also needs to be changed.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 8, 2023
@mergify mergify bot closed this as completed in #29140 Sep 11, 2023
mergify bot pushed a commit that referenced this issue Sep 11, 2023
@github-project-automation github-project-automation bot moved this from Open Cert Blockers to Complete in [Certification] Blockers Sep 11, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in [Feature] Mode Select Sep 11, 2023
abpoth pushed a commit to abpoth/connectedhomeip that referenced this issue Sep 12, 2023
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-clusters Application cluster work mode select Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation v1.2
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants