Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XML] Update Time Format Localization Cluster XML to match updated spec #24999

Closed
ReneJosefsen opened this issue Feb 11, 2023 · 0 comments · Fixed by #25289
Closed

[XML] Update Time Format Localization Cluster XML to match updated spec #24999

ReneJosefsen opened this issue Feb 11, 2023 · 0 comments · Fixed by #25289
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)

Comments

@ReneJosefsen
Copy link
Contributor

ReneJosefsen commented Feb 11, 2023 •
edited
Loading

The data types names has been updated in Time Format Localization Cluster and must be updated in the XML as well.

Updated
CalendarType -> CalendarTypeEnum
HourFormat -> HourFormatEnum

Spec PR: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6184 (already merged)
@bzbarsky-apple bzbarsky-apple added the Spec XML align SDK XML does not match the spec (including naming, etc) label Feb 13, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 23, 2023
@bzbarsky-apple
Align Time Format Localization cluster XML to spec changes.
00f7f3d 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6184.

Fixes project-chip#24999
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 23, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 23, 2023
@bzbarsky-apple
Align Time Format Localization cluster XML to spec changes.
767c49c 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6184.

Fixes project-chip#24999
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 24, 2023
@bzbarsky-apple
Align Time Format Localization cluster XML to spec changes.
f6ba741 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6184.

Fixes project-chip#24999
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 28, 2023
@bzbarsky-apple
Align Time Format Localization cluster XML to spec changes.
7598746 
Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6184.

Fixes project-chip#24999
yufengwangca pushed a commit that referenced this issue Feb 28, 2023
@bzbarsky-apple
Align Time Format Localization cluster XML to spec changes. (#25289)
6788cdb 
* Align Time Format Localization cluster XML to spec changes.

Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6184.

Fixes #24999

* Auto-update ZAP files.

* Regenerate generated code.
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Align Time Format Localization cluster XML to spec changes. (#25289)
b4ecb2d 
* Align Time Format Localization cluster XML to spec changes.

Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6184.

Fixes project-chip/connectedhomeip#24999

* Auto-update ZAP files.

* Regenerate generated code.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@bzbarsky-apple
Align Time Format Localization cluster XML to spec changes. (project-…
9b7ae14 
…chip#25289)

* Align Time Format Localization cluster XML to spec changes.

Spec changes happened in CHIP-Specifications/connectedhomeip-spec#6184.

Fixes project-chip#24999

* Auto-update ZAP files.

* Regenerate generated code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spec XML align SDK XML does not match the spec (including naming, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align Time Format Localization cluster XML to spec changes. bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @ReneJosefsen