Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various NetworkCommissioningWiFiDriver implementations have broken logging of spans #24271

Closed
bzbarsky-apple opened this issue Jan 4, 2023 · 0 comments · Fixed by #25318
Closed

Various NetworkCommissioningWiFiDriver implementations have broken logging of spans #24271

bzbarsky-apple opened this issue Jan 4, 2023 · 0 comments · Fixed by #25318
Labels
crash

Comments

@bzbarsky-apple
Copy link
Contributor 

src/platform/Linux/NetworkCommissioningWiFiDriver.cpp:    ChipLogProgress(NetworkProvisioning, "LinuxNetworkCommissioningDelegate: SSID: %s",
src/platform/nxp/mw320/NetworkCommissioningWiFiDriver.cpp:    ChipLogProgress(NetworkProvisioning, "LinuxNetworkCommissioningDelegate: SSID: %s", networkId.data());
src/platform/webos/NetworkCommissioningWiFiDriver.cpp:    ChipLogProgress(NetworkProvisioning, "LinuxNetworkCommissioningDelegate: SSID: %s", networkId.data());

all of those are logging a ByteSpan's pointer as %s but there is no reason the data woul be null-terminated. This can lead to crashes and other bad things.
@bzbarsky-apple bzbarsky-apple mentioned this issue Jan 4, 2023
Closed
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 24, 2023
@bzbarsky-apple
Stop assuming spans are null-terminated in WiFi driver impls.
3b82da4 
Fixes project-chip#24271
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 24, 2023
Merged
yufengwangca pushed a commit that referenced this issue Feb 27, 2023
@bzbarsky-apple
Stop assuming spans are null-terminated in WiFi driver impls. (#25318)
29851c2 
Fixes #24271
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Stop assuming spans are null-terminated in WiFi driver impls. (#25318)
f64b9ae 
Fixes project-chip/connectedhomeip#24271
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@bzbarsky-apple
Stop assuming spans are null-terminated in WiFi driver impls. (projec…
38d6373 
…t-chip#25318)

Fixes project-chip#24271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop assuming spans are null-terminated in WiFi driver impls. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple