Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand out "pai" and "dac" and "cert" in Darwin APIs #23915

Closed
bzbarsky-apple opened this issue Dec 5, 2022 · 1 comment · Fixed by #23937
Closed

Expand out "pai" and "dac" and "cert" in Darwin APIs #23915

bzbarsky-apple opened this issue Dec 5, 2022 · 1 comment · Fixed by #23937
Labels
api darwin

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Dec 5, 2022 •
edited
Loading

Should use productAttestationIntermediateCertificate and deviceAttestationCertificate and Certificate.
@bzbarsky-apple
Copy link
Contributor Author

bzbarsky-apple commented Dec 5, 2022 •
edited
Loading

I think in practice this comes down to these bits, apart from backwards-compat APIs, at this point:

src/darwin/Framework/CHIP/MTRDeviceControllerFactory.h:@property (nonatomic, copy, nullable) NSArray<NSData *> * paaCerts;
src/darwin/Framework/CHIP/MTRDeviceControllerFactory.h:@property (nonatomic, copy, nullable) NSArray<NSData *> * cdCerts;

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Dec 6, 2022
@bzbarsky-apple
Stop using the "cd", "paa", "certs" abbreviations in Darwin APIs.
a095830 
Fixes project-chip#23915
@bzbarsky-apple bzbarsky-apple mentioned this issue Dec 6, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Dec 7, 2022
@bzbarsky-apple
Stop using the "cd", "paa", "certs" abbreviations in Darwin APIs.
56bd908 
Fixes project-chip#23915
bzbarsky-apple added a commit that referenced this issue Dec 7, 2022
@bzbarsky-apple
Stop using the "cd", "paa", "certs" abbreviations in Darwin APIs. (#2…
f2f082a 
…3937)

Fixes #23915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using the "cd", "paa", "certs" abbreviations in Darwin APIs. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple