Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving more functionality to Darwin MTRCallbackBridgeBase #23597

Closed
bzbarsky-apple opened this issue Nov 14, 2022 · 0 comments · Fixed by #24738
Closed

Consider moving more functionality to Darwin MTRCallbackBridgeBase #23597

bzbarsky-apple opened this issue Nov 14, 2022 · 0 comments · Fixed by #24738
Assignees
@bzbarsky-apple
Labels
darwin v1.2

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Nov 14, 2022 •
edited
Loading

Right now there is various state and functionality on MTRCallbackBridge that does not really depend on the callback type. We could move that up to MTRCallbackBridgeBase.
@bzbarsky-apple bzbarsky-apple mentioned this issue Nov 14, 2022
Merged
@bzbarsky-apple bzbarsky-apple self-assigned this Jan 29, 2023
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 30, 2023
@bzbarsky-apple
Move shared callback bridge functionality to MTRCallbackBridgeBase.
051749d 
Also eliminates the last direct (and hence not interceptible by API consumers)
NSLog calls in the Darwin framework and adds a lint for those.

Fixes project-chip#23597
@bzbarsky-apple bzbarsky-apple mentioned this issue Jan 30, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 2, 2023
@bzbarsky-apple
Move shared callback bridge functionality to MTRCallbackBridgeBase.
f7601a6 
Also eliminates the last direct (and hence not interceptible by API consumers)
NSLog calls in the Darwin framework and adds a lint for those.

Fixes project-chip#23597
bzbarsky-apple added a commit that referenced this issue Feb 2, 2023
@bzbarsky-apple
Move shared callback bridge functionality to MTRCallbackBridgeBase. (#…
db8a271 
…24738)

Also eliminates the last direct (and hence not interceptible by API consumers)
NSLog calls in the Darwin framework and adds a lint for those.

Fixes #23597
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Move shared callback bridge functionality to MTRCallbackBridgeBase. (…
4e84433 
…#24738)

Also eliminates the last direct (and hence not interceptible by API consumers)
NSLog calls in the Darwin framework and adds a lint for those.

Fixes project-chip/connectedhomeip#23597
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
@bzbarsky-apple @kkasperczyk-no
Move shared callback bridge functionality to MTRCallbackBridgeBase. (…
7eb62b2 
…#24738)

Also eliminates the last direct (and hence not interceptible by API consumers)
NSLog calls in the Darwin framework and adds a lint for those.

Fixes project-chip/connectedhomeip#23597
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
@bzbarsky-apple
Move shared callback bridge functionality to MTRCallbackBridgeBase. (p…
12b5bec 
…roject-chip#24738)

Also eliminates the last direct (and hence not interceptible by API consumers)
NSLog calls in the Darwin framework and adds a lint for those.

Fixes project-chip#23597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move shared callback bridge functionality to MTRCallbackBridgeBase. bzbarsky-apple/connectedhomeip
2 participants
@woody-apple @bzbarsky-apple