Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spake2pVerifier::Generate should not take the passcode by non-const reference #23511

Closed
bzbarsky-apple opened this issue Nov 4, 2022 · 0 comments · Fixed by #23571
Closed

Spake2pVerifier::Generate should not take the passcode by non-const reference #23511

bzbarsky-apple opened this issue Nov 4, 2022 · 0 comments · Fixed by #23571

Comments

@bzbarsky-apple
Copy link
Contributor

It does not modify the argument; it should just take it by value.
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Nov 10, 2022
@bzbarsky-apple
Stop passing passcode by mutable reference to Spake2pVerifier::Generate.
4fe6b21 
The generation bits never modify the passcode.

Fixes project-chip#23511
@bzbarsky-apple bzbarsky-apple mentioned this issue Nov 10, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Nov 10, 2022
@bzbarsky-apple
Stop passing passcode by mutable reference to Spake2pVerifier::Generate.
9193e8e 
The generation bits never modify the passcode.

Fixes project-chip#23511
bzbarsky-apple added a commit that referenced this issue Nov 11, 2022
@bzbarsky-apple
Stop passing passcode by mutable reference to Spake2pVerifier::Genera…
008df4d 
…te. (#23571)

The generation bits never modify the passcode.

Fixes #23511
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this issue Nov 18, 2022
@bzbarsky-apple @adbridge
Stop passing passcode by mutable reference to Spake2pVerifier::Genera…
49d78f5 
…te. (project-chip#23571)

The generation bits never modify the passcode.

Fixes project-chip#23511
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this issue Nov 18, 2022
@bzbarsky-apple @adbridge
Stop passing passcode by mutable reference to Spake2pVerifier::Genera…
9aff835 
…te. (project-chip#23571)

The generation bits never modify the passcode.

Fixes project-chip#23511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bzbarsky-apple