Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to address review comments on PR 22112 #22205

Closed
bzbarsky-apple opened this issue Aug 27, 2022 · 1 comment · Fixed by #22433
Closed

Need to address review comments on PR 22112 #22205

bzbarsky-apple opened this issue Aug 27, 2022 · 1 comment · Fixed by #22433
Assignees
@bzbarsky-apple
Labels
darwin V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

See #22112 (review)

Most importantly, on errors the API returns garbage instead of failing in some sane way.

Proposed Solution

Address comments.

@mburshteyn1
@bzbarsky-apple
Copy link
Contributor Author

And also #22112 (comment)

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 6, 2022
@bzbarsky-apple
Address review comments on PR 22205.
c785e92 
Stops unnecessarily using CHIPDeviceController instances.  Stops
manually serializing verifiers when we have utilities for that.

Fixes project-chip#22205
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 6, 2022
Merged
woody-apple pushed a commit that referenced this issue Sep 7, 2022
@bzbarsky-apple
Address review comments on PR 22205. (#22433)
5219c73 
Stops unnecessarily using CHIPDeviceController instances.  Stops
manually serializing verifiers when we have utilities for that.

Fixes #22205
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Address review comments on PR 22205. (project-chip#22433)
f2fcc4d 
Stops unnecessarily using CHIPDeviceController instances.  Stops
manually serializing verifiers when we have utilities for that.

Fixes project-chip#22205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address review comments on PR 22205. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple