Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chip-tool: add more flexibility in PAA root folder selection #21681

Closed
bluebin14 opened this issue Aug 5, 2022 · 2 comments · Fixed by #21691
Closed

chip-tool: add more flexibility in PAA root folder selection #21681

bluebin14 opened this issue Aug 5, 2022 · 2 comments · Fixed by #21691
Assignees

Comments

@bluebin14
Copy link
Contributor

Problem

chip-tool currently can only select a PAA root folder by command line argument. This presents an integration problem in various existing certification tools since a large amount of calls in several scripts would need to be changed. Instead there is a need for more flexibility in specifying PAA root folder which only requires a backwards compatible change to chip-tool.

Proposed Solution

The following to be applied to chip-tool if --paa-trust-store-path is not given:

if ~/paa-root-certs exists use that
else if environment variable PAA_ROOT_CERTS exists use that 
@tcarmelveilleux
Copy link
Contributor

Assigned to @kpschoedel, he may have time within the next few days. Otherwise we will reassign.

I would recommend against ~/paa-root-certs -> this can be achieved by having PAA_ROOT_CERTS environment variable set to ~/paa-root-certs in the shell's profile by default, which would avoid special casing.

@bluebin14
Copy link
Contributor Author

yes, PAA_ROOT_CERTS should be sufficient

kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this issue Aug 5, 2022
#### Problem

Fixes project-chip#21681 chip-tool: add more flexibility in PAA root folder selection

#### Change overview

If `--paa-trust-store-path` is not given, and the environment variable
`CHIPTOOL_PAA_TRUST_STORE_PATH` exists, use its value.

#### Testing

Manual confirmation of the logged `mPaaTrustStorePath.Value()`.
tcarmelveilleux pushed a commit that referenced this issue Aug 8, 2022
* chip-tool: add more flexibility in PAA root folder selection

#### Problem

Fixes #21681 chip-tool: add more flexibility in PAA root folder selection

#### Change overview

If `--paa-trust-store-path` is not given, and the environment variable
`CHIPTOOL_PAA_TRUST_STORE_PATH` exists, use its value.

#### Testing

Manual confirmation of the logged `mPaaTrustStorePath.Value()`.

* restyled
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
…-chip#21691)

* chip-tool: add more flexibility in PAA root folder selection

#### Problem

Fixes project-chip#21681 chip-tool: add more flexibility in PAA root folder selection

#### Change overview

If `--paa-trust-store-path` is not given, and the environment variable
`CHIPTOOL_PAA_TRUST_STORE_PATH` exists, use its value.

#### Testing

Manual confirmation of the logged `mPaaTrustStorePath.Value()`.

* restyled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants