Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the zpro encoder/decoder to using BufBound #2073

Closed
bzbarsky-apple opened this issue Aug 11, 2020 · 2 comments · Fixed by #2103
Closed

Switch the zpro encoder/decoder to using BufBound #2073

bzbarsky-apple opened this issue Aug 11, 2020 · 2 comments · Fixed by #2103
Assignees
@bhaskar-apple
Labels
feature request

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

There's a bunch of manual buffer management code in src/app/chip-zcl-zpro/command-encoder/encoder.c that can use BufBound now that @rwalker-apple's #1947 has landed.

Proposed Solution

Switch these files from C to C++ (still with an extern "C" API) and use BufBound where appropriate.
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.84. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@bzbarsky-apple bzbarsky-apple mentioned this issue Aug 11, 2020
Merged
@bhaskar-apple
Copy link
Contributor

Working on this currently

bhaskar-apple pushed a commit to bhaskar-apple/connectedhomeip that referenced this issue Aug 13, 2020
@Bhaskar-Sarma
Switch the zpro encoder/decoder to using BufBound project-chip#2073
ec96966
bhaskar-apple pushed a commit to bhaskar-apple/connectedhomeip that referenced this issue Aug 13, 2020
@Bhaskar-Sarma
Switch the zpro encoder/decoder to using BufBound project-chip#2073
8a10c92
@bhaskar-apple bhaskar-apple mentioned this issue Aug 13, 2020
Merged
bhaskar-apple pushed a commit to bhaskar-apple/connectedhomeip that referenced this issue Aug 13, 2020
@Bhaskar-Sarma
Switch the zpro encoder/decoder to using BufBound project-chip#2073
e9e5ccf
bhaskar-apple pushed a commit to bhaskar-apple/connectedhomeip that referenced this issue Aug 20, 2020
@Bhaskar-Sarma
Switch the zpro encoder/decoder to using BufBound project-chip#2073
4172daf
bhaskar-apple pushed a commit to bhaskar-apple/connectedhomeip that referenced this issue Aug 21, 2020
@Bhaskar-Sarma
Switch the zpro encoder/decoder to using BufBound project-chip#2073
cda51db
bhaskar-apple pushed a commit to bhaskar-apple/connectedhomeip that referenced this issue Aug 25, 2020
@Bhaskar-Sarma
Switch the zpro encoder/decoder to using BufBound project-chip#2073
ee4c463
woody-apple pushed a commit that referenced this issue Aug 25, 2020
@bhaskar-apple @Bhaskar-Sarma
#2073 Switch the zpro encoder/decoder to using BufBound (#2103)
14263d9 
* Switch the zpro encoder/decoder to using BufBound #2073

* Replace extraneous printf

* Fix build

* PR Feedback

* Fix the measure case for encodeAPSFrame

* PR Feedback round 2

* PR feedback round 3

Co-authored-by: Bhaskar Sarma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhaskar-apple bhaskar-apple

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2073 Switch the zpro encoder/decoder to using BufBound bhaskar-apple/connectedhomeip
2 participants
@bhaskar-apple @bzbarsky-apple