Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master Is Broken with Failed 'make distcheck' #201

Closed
gerickson opened this issue Apr 1, 2020 · 2 comments · Fixed by #204
Closed

Master Is Broken with Failed 'make distcheck' #201

gerickson opened this issue Apr 1, 2020 · 2 comments · Fixed by #204
Assignees
Milestone

Comments

@gerickson
Copy link
Contributor

Problem

The top of tree master branch is broken due to a failed make distcheck:

Making all in system
Making all in tests
make[5]: Nothing to be done for 'all'.
  CXX      ../../src/system/libSystemLayer_a-SystemClock.o
  CXX      ../../src/system/libSystemLayer_a-SystemError.o
  CXX      ../../src/system/libSystemLayer_a-SystemLayer.o
  CXX      ../../src/system/libSystemLayer_a-SystemMutex.o
  CXX      ../../src/system/libSystemLayer_a-SystemObject.o
  CXX      ../../src/system/libSystemLayer_a-SystemTimer.o
  CXX      ../../src/system/libSystemLayer_a-SystemPacketBuffer.o
  CXX      ../../src/system/libSystemLayer_a-SystemStats.o
  CXX      ../../src/system/libSystemLayer_a-SystemFaultInjection.o
  AR       libSystemLayer.a
ar: `u' modifier ignored since `D' is the default (see `U')
make[4]: Nothing to be done for 'all-am'.
Making all in tests
make[4]: Nothing to be done for 'all-am'.
make[3]: Nothing to be done for 'all-am'.
  DISTCHECK    x86_64-unknown-linux-gnu
make -j2 -C build/x86_64-unknown-linux-gnu --no-print-directory distcheck
  CHECK         .local-version
make --no-print-directory dist-gzip am__post_remove_distdir='@:'
make[2]: *** No rule to make target 'BUILDING.md', needed by 'distdir'.  Stop.
make[1]: *** [dist] Error 2
Makefile:902: recipe for target 'dist' failed
make: *** [distcheck-x86_64-unknown-linux-gnu] Error 2
Makefile-Standalone:423: recipe for target 'distcheck-x86_64-unknown-linux-gnu' failed
##[error]Process completed with exit code 2.

Proposed Solution

Find the offending makefile(s) and ensure BUILDING.md is appropriately captured as a project file.

@woody-apple
Copy link
Contributor

Confirm this happens in VSCode environment too

@woody-apple woody-apple self-assigned this Apr 1, 2020
@woody-apple woody-apple added this to the M4.1 milestone Apr 1, 2020
@woody-apple
Copy link
Contributor

I broke this moving the BUILDING.md file

@woody-apple woody-apple linked a pull request Apr 1, 2020 that will close this issue
mkardous-silabs referenced this issue in mkardous-silabs/connectedhomeip Nov 2, 2022
Merge in WMN_TOOLS/matter from feature/update_submodule to silabs_1.0

Squashed commit of the following:

commit c2145572e5d5c4d347f04253e7f3dca65013e8e3
Author: Mathieu Kardous <[email protected]>
Date:   Mon Oct 24 08:36:04 2022 -0400

    Update submodule - pull in brd4317a fix
rerasool pushed a commit to SiliconLabs/matter that referenced this issue Nov 2, 2022
Merge in WMN_TOOLS/matter from feature/update_submodule to silabs_1.0

Squashed commit of the following:

commit c2145572e5d5c4d347f04253e7f3dca65013e8e3
Author: Mathieu Kardous <[email protected]>
Date:   Mon Oct 24 08:36:04 2022 -0400

    Update submodule - pull in brd4317a fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants