Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test_TC_CGEN_2_1.yaml BasicCommissioningInfo should not use specific hardcoded values #19620

Closed
tehampson opened this issue Jun 15, 2022 · 4 comments

Comments

@tehampson
Copy link
Contributor

tehampson commented Jun 15, 2022

Problem

After #19582 this xml looks like

          value:
              {
                  FailSafeExpiryLengthSeconds: 60,
                  MaxCumulativeFailsafeSeconds: 900,
              }

While these are the default values they are not the required values and cert testing should just make sure that these fields are populated with some value greater than 0

@bzbarsky-apple
Copy link
Contributor

@kowsisoundhar12 please take a look?

@woody-apple
Copy link
Contributor

@raju-apple can you make sure the test case steps are also updated, it sounds like we need to fix both the YAML and maybe the test steps.

@raju-apple
Copy link
Contributor

Currently looks like we don't have a way to check the range within a struct value in yaml (#17997) , But for now we can put up a manual user prompt just for this step for the user to validate its within the range and not checking a specific value. @kvikrambhat Can you please put the PR for this modified script once its up please ?

woody-apple pushed a commit that referenced this issue Jun 22, 2022
* Modified test CGEN_2_1

* Added auto generated files

* Modified script CGEN-2.1

* Auto generated files
@franck-apple
Copy link

Solved in #19672. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants