-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out what to do with emberAfStackDown #1940
Comments
Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Still an issue. |
@bzbarsky-apple does this need to be fixed for 1.0? |
I doubt it, except insofar as this was doing something important in the original silabs code (what?) and we should make sure we are doing that in Matter. @selissia do you know what this function was supposed to do? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This stale issue has been automatically closed. Thank you for your contributions. |
This is unused and does nothing. Fixes project-chip#1940
This is unused and does nothing. Fixes #1940
This is unused and does nothing. Fixes project-chip/connectedhomeip#1940
This is unused and does nothing. Fixes project-chip/connectedhomeip#1940
This is unused and does nothing. Fixes project-chip#1940
Problem
The initial landing in #1609 includes a function called
emberAfStackDown
inutil.c
that none of the other pulled-in code seems to use. It's called fromaf-main-common.c
in the original silabs code.Various parts of this function (calls to
emberStackIsPerformingRejoin
,emberNetworkState
,emberGetCurrentNetwork
) were commented out to make it compile.Proposed Solution
We should figure out whether something in the CHIP stack should be calling this function. If so, we need to figure out what that "something" is, and what to do with the commented-out pieces.
@bhaskar-apple @rwalker-apple @selissia @wehale @tecimovic
The text was updated successfully, but these errors were encountered: