Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what to do with emberAfStackDown #1940

Closed
bzbarsky-apple opened this issue Jul 31, 2020 · 7 comments · Fixed by #25296
Closed

Figure out what to do with emberAfStackDown #1940

bzbarsky-apple opened this issue Jul 31, 2020 · 7 comments · Fixed by #25296
Labels
bug Something isn't working p1 priority 1 work V1.X
Milestone

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

The initial landing in #1609 includes a function called emberAfStackDown in util.c that none of the other pulled-in code seems to use. It's called from af-main-common.c in the original silabs code.

Various parts of this function (calls to emberStackIsPerformingRejoin, emberNetworkState, emberGetCurrentNetwork) were commented out to make it compile.

Proposed Solution

We should figure out whether something in the CHIP stack should be calling this function. If so, we need to figure out what that "something" is, and what to do with the commented-out pieces.

@bhaskar-apple @rwalker-apple @selissia @wehale @tecimovic

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@woody-apple woody-apple added this to the V1.0 milestone Aug 3, 2020
@woody-apple woody-apple added bug Something isn't working and removed triage labels Aug 3, 2020
@franck-apple franck-apple added the p2 priority 2 work label Oct 16, 2020
@woody-apple woody-apple added p1 priority 1 work and removed p2 priority 2 work labels Oct 22, 2020
@stale
Copy link

stale bot commented Oct 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Oct 22, 2021
@bzbarsky-apple
Copy link
Contributor Author

Still an issue.

@holbrookt
Copy link
Contributor

@bzbarsky-apple does this need to be fixed for 1.0?

@bzbarsky-apple
Copy link
Contributor Author

I doubt it, except insofar as this was doing something important in the original silabs code (what?) and we should make sure we are doing that in Matter.

@selissia do you know what this function was supposed to do?

@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 31, 2022
@stale
Copy link

stale bot commented Oct 9, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 9, 2022
@bzbarsky-apple bzbarsky-apple removed the stale Stale issue or PR label Oct 10, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 24, 2023
This is unused and does nothing.

Fixes project-chip#1940
andy31415 pushed a commit that referenced this issue Feb 24, 2023
This is unused and does nothing.

Fixes #1940
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
kkasperczyk-no pushed a commit to kkasperczyk-no/sdk-connectedhomeip that referenced this issue Mar 15, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p1 priority 1 work V1.X
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants