Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "constexpr CASEAuthTag IsValidCASEAuthTag(CASEAuthTag aCAT)" return type maybe bool #19145

Closed
nykh2010 opened this issue Jun 3, 2022 · 2 comments · Fixed by #19189
Closed

The "constexpr CASEAuthTag IsValidCASEAuthTag(CASEAuthTag aCAT)" return type maybe bool #19145

nykh2010 opened this issue Jun 3, 2022 · 2 comments · Fixed by #19189

Comments

@nykh2010
Copy link

nykh2010 commented Jun 3, 2022

connectedhomeip/src/lib/core/CASEAuthTag.h

Line 97 in 8dabae0

constexpr CASEAuthTag IsValidCASEAuthTag(CASEAuthTag aCAT)

The return type maybe bool.
@nykh2010 nykh2010 changed the title The return type maybe bool The "constexpr CASEAuthTag IsValidCASEAuthTag(CASEAuthTag aCAT)" return type maybe bool Jun 3, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jun 3, 2022
@bzbarsky-apple
Fix signature of IsValidCASEAuthTag.
4e3998e 
Fixes project-chip#19145
@bzbarsky-apple bzbarsky-apple mentioned this issue Jun 3, 2022
Merged
@bzbarsky-apple
Copy link
Contributor

Nice catch, thank you!

@emargolis
Copy link
Contributor

Indeed! Thanks!

isiu-apple pushed a commit that referenced this issue Jun 3, 2022
@bzbarsky-apple
Fix signature of IsValidCASEAuthTag. (#19189)
6443f77 
Fixes #19145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix signature of IsValidCASEAuthTag. bzbarsky-apple/connectedhomeip
3 participants
@emargolis @nykh2010 @bzbarsky-apple