Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Door-Lock-Server] Server sets LockState to 'Locked' upon initialization #18677

Closed
jrhees-cae opened this issue May 20, 2022 · 1 comment · Fixed by #18914
Closed

[Door-Lock-Server] Server sets LockState to 'Locked' upon initialization #18677

jrhees-cae opened this issue May 20, 2022 · 1 comment · Fixed by #18914
Labels
app-clusters Application cluster work examples p1 priority 1 work V1.0

Comments

@jrhees-cae
Copy link
Contributor

Problem

door-lock-server's InitServer method sets the LockState to 'Locked'.

This creates two unwanted side effects:

  1. LockState is assumed as 'Locked' until the application changes it (which could be misconstrued by a client).
  2. A Lock-Operation-Event is generated in the Event List that says that the door was locked, which is not true.

Proposed Solution

Suggest modifying to set the LockState to null.

From the spec: "The LockState Attribute may be NULL if the lock hardware does not currently know the status of the locking mechanism. For example, a lock may not know the LockState status after a power cycle until the first lock actuation is completed."

@mrjerryjohns
Copy link
Contributor

mrjerryjohns commented May 23, 2022

Seems pretty critical given that lock state is a core attribute for the cluster, and it should not be showing an inaccurate state relative to the true state of the lock.

@mrjerryjohns mrjerryjohns added V1.0 app-clusters Application cluster work spec Mismatch between spec and implementation labels May 23, 2022
@woody-apple woody-apple added examples p1 priority 1 work and removed spec Mismatch between spec and implementation labels May 27, 2022
Morozov-5F added a commit to Morozov-5F/connectedhomeip that referenced this issue May 27, 2022
- Set the actual lock state from the app without event generation
andy31415 pushed a commit that referenced this issue May 30, 2022
- Set the actual lock state from the app without event generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-clusters Application cluster work examples p1 priority 1 work V1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants