Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnReadInitialRequest has a useless return value #17623

Closed
bzbarsky-apple opened this issue Apr 22, 2022 · 0 comments · Fixed by #18706
Closed

OnReadInitialRequest has a useless return value #17623

bzbarsky-apple opened this issue Apr 22, 2022 · 0 comments · Fixed by #18706

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Apr 22, 2022 •
edited
Loading

Problem

OnReadInitialRequest returns a CHIP_ERROR, but the caller ignores it.

Proposed Solution

Fix things so that we either return the InteractionModel::Status the caller cares about or return a CHIP_ERROR that the caller then uses to set the status (and it's on OnReadInitialRequest to make it an error that carries a status).
@bzbarsky-apple bzbarsky-apple mentioned this issue May 4, 2022
Closed
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 21, 2022
@bzbarsky-apple
Make the error-handling in OnReadInitialRequest clearer.
d9619ea 
Instead of having both a status outparam and an error return, just use a status return.

Also fixes some bugs where we were not checking the results of some
TLV parsing operations, and not converting some TVL parsing failures
to the right status.

Fixes project-chip#11724

Fixes project-chip#17623
@bzbarsky-apple bzbarsky-apple mentioned this issue May 21, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 25, 2022
@bzbarsky-apple
Make the error-handling in OnReadInitialRequest clearer.
ec99391 
Instead of having both a status outparam and an error return, just use a status return.

Also fixes some bugs where we were not checking the results of some
TLV parsing operations, and not converting some TVL parsing failures
to the right status.

Fixes project-chip#11724

Fixes project-chip#17623
bzbarsky-apple added a commit that referenced this issue May 25, 2022
@bzbarsky-apple
Make the error-handling in OnReadInitialRequest clearer. (#18706)
f18efd8 
Instead of having both a status outparam and an error return, just use a status return.

Also fixes some bugs where we were not checking the results of some
TLV parsing operations, and not converting some TVL parsing failures
to the right status.

Fixes #11724

Fixes #17623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the error-handling in OnReadInitialRequest clearer. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple