Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple transports #1339

Closed
andy31415 opened this issue Jun 29, 2020 · 0 comments · Fixed by #1424
Closed

Add support for multiple transports #1339

andy31415 opened this issue Jun 29, 2020 · 0 comments · Fixed by #1424
Assignees
@andy31415
Milestone
V1.0

Comments

@andy31415
Copy link
Contributor

Problem

Sessions should support compile-time transport selection, including support for multiple transports.

Even with only UDP, ESP32 and others already have IPv6 and IPv4 UDP (we may eventually only support v6, but having both in parallel makes for a nice testing environment) and eventually we will have BLE and may also have TCP.

Proposed Solution

SessionManager transports should be compile time. Possible solutions would be #ifdeffing, templating, subclassing etc.

Templates would be prefferable (compiletime, typesafe) as long as generated code size is not negatively impacted.
@andy31415 andy31415 self-assigned this Jun 29, 2020
@woody-apple woody-apple added this to the V1.0 milestone Jun 30, 2020
This was referenced Jun 30, 2020
Closed
Merged
doru91 added a commit to doru91/connectedhomeip that referenced this issue Jan 13, 2022
@doru91
[K32W0] Fix OTA memory allocation
8c36012 
Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <[email protected]>
@doru91 doru91 mentioned this issue Jan 13, 2022
Merged
andy31415 pushed a commit that referenced this issue Jan 24, 2022
@doru91 @restyled-commits
[K32W0] Fix OTA memory allocation (#13530)
b7854c5 
* [K32W0] Fix OTA memory allocation

Use the non-buggy version from ESP32.
See also: #1339

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

* [K32W0] Remove unneeded memory free

Signed-off-by: Doru Gucea <[email protected]>

Co-authored-by: Restyled.io <[email protected]>
selissia pushed a commit to selissia/connectedhomeip that referenced this issue Jan 28, 2022
@doru91 @restyled-commits @selissia
[K32W0] Fix OTA memory allocation (project-chip#13530)
a7e90d9 
* [K32W0] Fix OTA memory allocation

Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <[email protected]>

* Restyled by clang-format

* [K32W0] Remove unneeded memory free

Signed-off-by: Doru Gucea <[email protected]>

Co-authored-by: Restyled.io <[email protected]>
doru91 added a commit to doru91/connectedhomeip that referenced this issue Jan 31, 2022
@doru91
[K32W0] Fix OTA memory allocation
fa168aa 
Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <[email protected]>
doru91 added a commit to doru91/connectedhomeip that referenced this issue Feb 14, 2022
@doru91
[K32W0] Fix OTA memory allocation
9f6708d 
Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <[email protected]>
doru91 added a commit to doru91/connectedhomeip that referenced this issue Feb 14, 2022
@doru91
[K32W0] Fix OTA memory allocation
90c2dd7 
Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <[email protected]>
doru91 added a commit to doru91/connectedhomeip that referenced this issue Feb 15, 2022
@doru91
[K32W0] Fix OTA memory allocation
f66874d 
Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <[email protected]>
doru91 added a commit to doru91/connectedhomeip that referenced this issue Feb 15, 2022
@doru91
[K32W0] Fix OTA memory allocation
fc1401e 
Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <[email protected]>
doru91 added a commit to doru91/connectedhomeip that referenced this issue Feb 21, 2022
@doru91
[K32W0] Fix OTA memory allocation
a7b1672 
Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <[email protected]>
doru91 added a commit to doru91/connectedhomeip that referenced this issue Mar 4, 2022
@doru91
[K32W0] Fix OTA memory allocation
84eb6d4 
Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <[email protected]>
doru91 added a commit to doru91/connectedhomeip that referenced this issue Mar 27, 2022
@doru91
[K32W0] Fix OTA memory allocation
1756714 
Use the non-buggy version from ESP32.
See also: project-chip#1339

Signed-off-by: Doru Gucea <[email protected]>

[K32W0] Remove unneeded memory free

Signed-off-by: Doru Gucea <[email protected]>

OTA fixes

* avoid sending a new block request before the first block is being received;
* add the correct lighting clusters file;
* guard application OTA code;
* increase OTA buffers;
* add function to allow setting the max download block size in enericOTARequestorDriver;
* change FreeRTOS task priority such that the app task has a low priority than the chip task.

Signed-off-by: Doru Gucea <[email protected]>

Add OTA documentation

Signed-off-by: Doru Gucea <[email protected]>

Integrate pigweed tokenizer logging

*add pw_tokenizer build changes in /lib/support.
*add tokens database build changes in lighting-app.
*change ChipLog, emberAfPrintln and K32W_LOG lighting-app logging functions
 to use the tokenizer.
*guard tokenizer changes with define.
*split logs where too many arguments.
*updated pigweed submodule.

Signed-off-by: Andrei Menzopol <[email protected]>

Redirect OTA operations through platform scheduling

See the discussion from:
https://csamembers.slack.com/archives/G014G30SVV0/p1644588487457649

Signed-off-by: Doru Gucea <[email protected]>

Disable by default pigweed tokenizer

Signed-off-by: Doru Gucea <[email protected]>

Add detokenizer python script

Signed-off-by: Andrei Menzopol <[email protected]>

README updates

Signed-off-by: Doru Gucea <[email protected]>

Patch pw_env_setup arm-none-eabi not installed issue

Signed-off-by: Andrei Menzopol <[email protected]>

Update README

Signed-off-by: Doru Gucea <[email protected]>

Add debug logs in MemConfig.h

Signed-off-by: Doru Gucea <[email protected]>

E-Lock Demo Application fixes

* redirect cluster operations through platform scheduling
* avoid repetead PDM calls inside the AppTask

Signed-off-by: Doru Gucea <[email protected]>

OTA fixes

* lighting app: if compiled with OTA support then propagate the correct
defines (app total size, app starting poing) to the linker file;
* update signing script such that it automatically detects if OTA Signing
is needed;
* avoid applying a patch twice.

Signed-off-by: Doru Gucea <[email protected]>

Add changes for tinycrypt library

Signed-off-by: Andrei Menzopol <[email protected]>

Add support for processing the OTA header

Signed-off-by: Doru Gucea <[email protected]>

Add support for enabling tinycrypt usage from gn argument

Signed-off-by: Andrei Menzopol <[email protected]>

Fix NXP SDK patching

Signed-off-by: Doru Gucea <[email protected]>

Fix OtaSupport_c.patch

Signed-off-by: Doru Gucea <[email protected]>

plug app: clusters/application files

Signed-off-by: Ovidiu Usturoi <[email protected]>

Add support for enabling tokenizer usage from gn argument

Signed-off-by: Andrei Menzopol <[email protected]>

Fix tinycrypt mbedTLS error

Signed-off-by: Andrei Menzopol <[email protected]>

[TE8/rc3] Fix rebase issues

Please note that ACL entries must be granted on the OTA-provider side
to allow OTA-requestors - see the README.

Signed-off-by: Doru Gucea <[email protected]>

Avoid computing PBKDF on the commissionee side

Signed-off-by: Doru Gucea <[email protected]>

Update README

Signed-off-by: Andrei Menzopol <[email protected]>

Fix README

* add command for generating OTA Image

Signed-off-by: Doru Gucea <[email protected]>

Fix E-Lock locking

Signed-off-by: Doru Gucea <[email protected]>

[K32W0] Use correct board support files in different cases

[lighting-app, plug-app] update device state based on restored onoff attribute value

Signed-off-by: ovidiu-usturoi <[email protected]>

[plug-app, lighting-app, plug-app] updated sw version, [plug-app] updated readme and build args

Signed-off-by: ovidiu-usturoi <[email protected]>

[plug-app] updated device type & cluster list - zap files

Signed-off-by: ovidiu-usturoi <[email protected]>

Fix tinycrypt memory corruption

Signed-off-by: Doru Gucea <[email protected]>

Fix K32W0 lighting app README

Remove deprecated text

Signed-off-by: Doru Gucea <[email protected]>

Guard tinycrypt memory corruption fix

Signed-off-by: Andrei Menzopol <[email protected]>

Integrate tinycrypt in PASE

Signed-off-by: Andrei Menzopol <[email protected]>

Fix OTA

Allow sending ApplyUpdateRequest +  NotifyUpdateApplied.

Signed-off-by: Doru Gucea <[email protected]>

[K32W0] Allow SDK invoker to override DK6 board selection

[K32W0] Don't specify number of LEDs or buttons in SDK unless on DK6 board

[K32W0] Don't put PDM in external flash in SDK unless on DK6 board

FIxes after rebase to latest master

Signed-off-by: Doru Gucea <[email protected]>

Remove .bin

Signed-off-by: Doru Gucea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy31415 andy31415

Labels
None yet
Projects
None yet
Milestone
V1.0
2 participants
@andy31415 @woody-apple