-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chip-tool shutdowns when some contexts are still active when trying to open the commissioning window #11644
Comments
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Nov 10, 2021
PairingCommand::RunCommand called mController.RegisterPairingDelegate even in the open-commissioning-window case. Then when the device was connected we'd land in DeviceCommissioner::OnDeviceConnectedFn. This would call OnCommissioningComplete on the pairing delegate, which would land us in PairingCommand::OnCommissioningComplete and thinks the command is done. So we would exit without waiting for an actual response from the server and with exchanges still open. In PairingMode::OpenCommissioningWindow we should not be registering as a pairing delegate and whatnot; we are just sending normal cluster commands. Fixes project-chip#11644
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Nov 10, 2021
PairingCommand::RunCommand called mController.RegisterPairingDelegate even in the open-commissioning-window case. Then when the device was connected we'd land in DeviceCommissioner::OnDeviceConnectedFn. This would call OnCommissioningComplete on the pairing delegate, which would land us in PairingCommand::OnCommissioningComplete and thinks the command is done. So we would exit without waiting for an actual response from the server and with exchanges still open. In PairingMode::OpenCommissioningWindow we should not be registering as a pairing delegate and whatnot; we are just sending normal cluster commands. Fixes project-chip#11644
woody-apple
pushed a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Nov 10, 2021
PairingCommand::RunCommand called mController.RegisterPairingDelegate even in the open-commissioning-window case. Then when the device was connected we'd land in DeviceCommissioner::OnDeviceConnectedFn. This would call OnCommissioningComplete on the pairing delegate, which would land us in PairingCommand::OnCommissioningComplete and thinks the command is done. So we would exit without waiting for an actual response from the server and with exchanges still open. In PairingMode::OpenCommissioningWindow we should not be registering as a pairing delegate and whatnot; we are just sending normal cluster commands. Fixes project-chip#11644
woody-apple
pushed a commit
that referenced
this issue
Nov 11, 2021
PairingCommand::RunCommand called mController.RegisterPairingDelegate even in the open-commissioning-window case. Then when the device was connected we'd land in DeviceCommissioner::OnDeviceConnectedFn. This would call OnCommissioningComplete on the pairing delegate, which would land us in PairingCommand::OnCommissioningComplete and thinks the command is done. So we would exit without waiting for an actual response from the server and with exchanges still open. In PairingMode::OpenCommissioningWindow we should not be registering as a pairing delegate and whatnot; we are just sending normal cluster commands. Fixes #11644
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this issue
Dec 3, 2021
…1645) PairingCommand::RunCommand called mController.RegisterPairingDelegate even in the open-commissioning-window case. Then when the device was connected we'd land in DeviceCommissioner::OnDeviceConnectedFn. This would call OnCommissioningComplete on the pairing delegate, which would land us in PairingCommand::OnCommissioningComplete and thinks the command is done. So we would exit without waiting for an actual response from the server and with exchanges still open. In PairingMode::OpenCommissioningWindow we should not be registering as a pairing delegate and whatnot; we are just sending normal cluster commands. Fixes project-chip#11644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Chip-tool shutdowns when some contexts are still active when trying to open the commissioning window.
Command:
./connectedhomeip/out/chip-tool/chip-tool pairing open-commissioning-window <nodeid> 1 100 1000 3840
Controller logs:
Related code :
src/messaging/ExchangeMgr.cpp line 96
The text was updated successfully, but these errors were encountered: