Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<tag> support seems to be broken in ZAP, leading to database #11057

Closed
todo bot opened this issue Oct 27, 2021 · 0 comments · Fixed by #11711
Closed

<tag> support seems to be broken in ZAP, leading to database #11057

todo bot opened this issue Oct 27, 2021 · 0 comments · Fixed by #11711
Assignees
@bzbarsky-apple
Labels
todo

Comments

@todo
Copy link

todo bot commented Oct 27, 2021

connectedhomeip/src/app/zap-templates/zcl/data-model/chip/window-covering.xml

Lines 24 to 32 in 9a618bb

<!-- TODO: <tag> support seems to be broken in ZAP, leading to database
constraint errors
<tag name="LF" description="Lift Control"/>
<tag name="TL" description="Tilt Control"/>
<tag name="PA" description="Position Aware"/>
<tag name="ABS" description="Absolute Positioning"/> -->
<globalAttribute side="server" code="0xFFFC" value="0x0001">
<featureBit tag="LF" bit="0">true</featureBit>
<featureBit tag="TL" bit="1">false</featureBit>

This issue was generated by todo based on a TODO comment in 9a618bb. It's been assigned to @bzbarsky-apple because they committed the code.
@todo todo bot added the todo label Oct 27, 2021
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Nov 12, 2021
@bzbarsky-apple
Uncomment the <tag> bits in window covering.
f53a308 
project-chip/zap#274 should have fixed the problem that caused them to be commented out.

Fixes project-chip#11056
Fixes project-chip#11057
@bzbarsky-apple bzbarsky-apple mentioned this issue Nov 12, 2021
Merged
woody-apple pushed a commit that referenced this issue Nov 12, 2021
@bzbarsky-apple
Uncomment the <tag> bits in window covering. (#11711)
3db50b1 
project-chip/zap#274 should have fixed the problem that caused them to be commented out.

Fixes #11056
Fixes #11057
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this issue Dec 3, 2021
@bzbarsky-apple
Uncomment the <tag> bits in window covering. (project-chip#11711)
3c82e7d 
project-chip/zap#274 should have fixed the problem that caused them to be commented out.

Fixes project-chip#11056
Fixes project-chip#11057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uncomment the <tag> bits in window covering. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple