Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_GetQRCodeString() is not implemented #107

Closed
pan-apple opened this issue Mar 24, 2020 · 2 comments
Closed

_GetQRCodeString() is not implemented #107

pan-apple opened this issue Mar 24, 2020 · 2 comments
Assignees
@bhaskar-apple @pan-apple
Milestone
May 8, 2020

Comments

@pan-apple
Copy link
Contributor

Problem

#104 removed support for DeviceDescriptor from ConfigurationManager. That in turn removed the implementation for _GetQRCodeString().

Proposed Solution

Identify the correct/new API that replaces DeviceDescriptor. Re-implement _GetQRCodeString using this API.
@rwalker-apple rwalker-apple added this to the M4 milestone Mar 25, 2020
@rwalker-apple
Copy link
Contributor

@bhaskar-apple @pan-apple can you guys re-assess this, please?

@rwalker-apple rwalker-apple modified the milestones: May 1, 2020, May 8, 2020 May 4, 2020
@pan-apple
Copy link
Contributor Author

Looks like CHIP's setup_payload does not depend on _GetQRCodeString() method. Closing the issue.

fkjagodzinski pushed a commit to fkjagodzinski/connectedhomeip that referenced this issue Mar 19, 2021
@pan-
Merge pull request project-chip#107 from lukgni/power_reset
5cb1b58 
Add system_reset() call to DoFactoryReset() function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhaskar-apple bhaskar-apple

@pan-apple pan-apple

Labels
None yet
Projects
None yet
Milestone
May 8, 2020
Development

No branches or pull requests
3 participants
@bhaskar-apple @pan-apple @rwalker-apple