[matter_yamltests] Ensure that the PICSChecker code does not throw if…

… no file is used
project-chip · Jan 24, 2023 · fa0d3db · fa0d3db
1 parent d15be4c
commit fa0d3db
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/scripts/py_matter_yamltests/matter_yamltests/pics_checker.py b/scripts/py_matter_yamltests/matter_yamltests/pics_checker.py
@@ -39,10 +39,11 @@ class InvalidPICSParsingError(Exception):
 
 class PICSChecker():
     """Class to compute a PICS expression"""
-    __pics: None
-    __expression_index: 0
 
     def __init__(self, pics_file: str):
+        self.__pics = {}
+        self.__expression_index = 0
+
         if pics_file is not None:
             self.__pics = self.__parse(pics_file)
 

diff --git a/scripts/py_matter_yamltests/test_pics_checker.py b/scripts/py_matter_yamltests/test_pics_checker.py
@@ -67,6 +67,11 @@
 
 
 class TestPICSChecker(unittest.TestCase):
+    def test_no_file(self):
+        pics_checker = PICSChecker(None)
+        self.assertIsInstance(pics_checker, PICSChecker)
+        self.assertFalse(pics_checker.check('A.A'))
+
     @patch('builtins.open', mock_open(read_data=empty_config))
     def test_empty_config(self):
         pics_checker = PICSChecker('')