Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable shorten 64 to 32 error for arm64 (do not make it fatal) (#23237)
Browse files Browse the repository at this point in the history
* Disable shorten 64 to 32 error for arm64 (do not make it fatal)

* Add a CI target that would catch these errors in future updates

* Restyle

* Fix typo and link to the pigweed update PR
andy31415 authored and pull[bot] committed Feb 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent d9c5bcb commit efba117
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/examples-linux-arm.yaml
Original file line number Diff line number Diff line change
@@ -73,6 +73,7 @@ jobs:
--target linux-arm64-chip-tool-ipv6only-clang \
--target linux-arm64-lock-clang \
--target linux-arm64-minmdns-clang \
--target linux-arm64-light-rpc-ipv6only-clang \
--target linux-arm64-thermostat-no-ble-clang \
build \
"
9 changes: 9 additions & 0 deletions build/config/compiler/BUILD.gn
Original file line number Diff line number Diff line change
@@ -259,6 +259,15 @@ config("strict_warnings") {
"-Wshorten-64-to-32",
"-Wformat-type-confusion",
]

# TODO: can make this back fatal in once pigweed updates can be taken again.
# See https://github.com/project-chip/connectedhomeip/pull/22079
#
# Currently `./scripts/build/build_examples.py --target linux-arm64-light-rpc-ipv6only-clang build`
# fails in third_party/pigweed/repo/pw_protobuf
if (current_cpu == "arm64" && current_os == "linux") {
cflags += [ "-Wno-error=shorten-64-to-32" ]
}
}

if (!is_asan && (current_os == "linux" || current_os == "android")) {

0 comments on commit efba117

Please sign in to comment.