Skip to content

Commit

Permalink
RPC: Refactor RPC examples for better code reuse, and add RPCs to EFR…
Browse files Browse the repository at this point in the history
… lock app (#11633)

* RPC: Move Rpc.cpp to platform

Reduce code duplication by moving the Rpc.cpp file to the platform.
This greatly reduces code required to add rpcs to examples.

* RPC: Add RPCs to EFR lock app
  • Loading branch information
rgoliver authored and pull[bot] committed Aug 15, 2023
1 parent b8571e9 commit e4058ec
Show file tree
Hide file tree
Showing 24 changed files with 578 additions and 663 deletions.
7 changes: 7 additions & 0 deletions examples/all-clusters-app/esp32/main/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -220,4 +220,11 @@ target_link_options(${COMPONENT_LIB}
"-T${PIGWEED_ROOT}/pw_tokenizer/pw_tokenizer_linker_sections.ld"
)

target_compile_options(${COMPONENT_LIB} PRIVATE
"-DPW_RPC_ATTRIBUTE_SERVICE=1"
"-DPW_RPC_BUTTON_SERVICE=1"
"-DPW_RPC_DEVICE_SERVICE=1"
"-DPW_RPC_LIGHTING_SERVICE=1"
"-DPW_RPC_LOCKING_SERVICE=1")

endif (CONFIG_ENABLE_PW_RPC)
352 changes: 0 additions & 352 deletions examples/all-clusters-app/esp32/main/Rpc.cpp

This file was deleted.

2 changes: 1 addition & 1 deletion examples/common/pigweed/protos/device_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ message DeviceInfo {

message FabricInfo {
uint32 fabric_id = 1;
uint32 node_id = 2;
uint64 node_id = 2;
}

message DeviceState {
Expand Down
Loading

0 comments on commit e4058ec

Please sign in to comment.