BLEEndPoint ref count overflow check (#16046)

* BLEEndPoint ref count overflow check * Assert preconditions for BLEEndPoint ref counting
project-chip · Mar 15, 2022 · ca52c2e · ca52c2e
1 parent 5370ccb
commit ca52c2e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/ble/BLEEndPoint.cpp b/src/ble/BLEEndPoint.cpp
@@ -586,8 +586,15 @@ CHIP_ERROR BLEEndPoint::Init(BleLayer * bleLayer, BLE_CONNECTION_OBJECT connObj,
     return CHIP_NO_ERROR;
 }
 
+void BLEEndPoint::AddRef()
+{
+    VerifyOrDie(mRefCount < UINT32_MAX);
+    mRefCount++;
+}
+
 void BLEEndPoint::Release()
 {
+    VerifyOrDie(mRefCount > 0u);
     // Decrement the ref count.  When it reaches zero, NULL out the pointer to the chip::System::Layer
     // object. This effectively declared the object free and ready for re-allocation.
     mRefCount--;

diff --git a/src/ble/BLEEndPoint.h b/src/ble/BLEEndPoint.h
@@ -114,7 +114,7 @@ class DLL_EXPORT BLEEndPoint
 
     uint32_t mRefCount;
 
-    void AddRef() { mRefCount++; }
+    void AddRef();
     void Release();
 
     // Private data members: