Fix error reporting in chip-tool. (#17760)

The actual error message got lost in #17628.
project-chip · Apr 27, 2022 · afe0fef · afe0fef
1 parent 7666b04
commit afe0fef
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/examples/chip-tool/commands/tests/TestCommand.cpp b/examples/chip-tool/commands/tests/TestCommand.cpp
@@ -77,7 +77,7 @@ void TestCommand::Exit(std::string message, CHIP_ERROR err)
 {
     mContinueProcessing = false;
 
-    LogEnd(err);
+    LogEnd(message, err);
 
     if (CHIP_NO_ERROR == err)
     {

diff --git a/examples/placeholder/linux/include/TestCommand.h b/examples/placeholder/linux/include/TestCommand.h
@@ -86,7 +86,7 @@ class TestCommand : public TestRunner,
 
     void Exit(std::string message, CHIP_ERROR err) override
     {
-        LogEnd(err);
+        LogEnd(message, err);
         SetCommandExitStatus(err);
     }
 

diff --git a/src/app/tests/suites/include/TestRunner.h b/src/app/tests/suites/include/TestRunner.h
@@ -33,15 +33,15 @@ class TestRunner
         ChipLogProgress(chipTool, " ***** Test Step %u : %s\n", stepNumber, stepName);
     }
 
-    void LogEnd(CHIP_ERROR err)
+    void LogEnd(std::string message, CHIP_ERROR err)
     {
         if (CHIP_NO_ERROR == err)
         {
-            ChipLogProgress(chipTool, " **** Test Complete: %s\n", mTestName);
+            ChipLogProgress(chipTool, " **** Test Complete: %s\n", message.c_str());
         }
         else
         {
-            ChipLogError(chipTool, " ***** Test Failure: %s\n", mTestName);
+            ChipLogError(chipTool, " ***** Test Failure: %s\n", message.c_str());
         }
     }
 
@@ -59,7 +59,6 @@ class TestRunner
 
         if (mTestCount == mTestIndex)
         {
-            LogEnd(CHIP_NO_ERROR);
             Exit(mTestName, CHIP_NO_ERROR);
             return;
         }