Address review comment.

project-chip · Nov 1, 2022 · a999e49 · a999e49
1 parent ab70e46
commit a999e49
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/darwin/Framework/CHIP/MTRDevice.mm b/src/darwin/Framework/CHIP/MTRDevice.mm
@@ -183,7 +183,7 @@ - (void)setDelegate:(id<MTRDeviceDelegate>)delegate queue:(dispatch_queue_t)queu
 
     _weakDelegate = [MTRWeakReference weakReferenceWithObject:delegate];
     _delegateQueue = queue;
-    [self subscribeWithMinInterval:0];
+    [self setupSubscription];
 
     os_unfair_lock_unlock(&self->_lock);
 }
@@ -286,7 +286,7 @@ - (void)_handleEventReport:(NSArray<NSDictionary<NSString *, id> *> *)eventRepor
     os_unfair_lock_unlock(&self->_lock);
 }
 
-- (void)subscribeWithMinInterval:(uint16_t)minInterval
+- (void)setupSubscription
 {
     // for now just subscribe once
     if (_subscriptionActive) {
@@ -312,7 +312,7 @@ - (void)subscribeWithMinInterval:(uint16_t)minInterval
                            eventPath->mIsUrgentEvent = true;
                            ReadPrepareParams readParams(session.Value());
 
-                           readParams.mMinIntervalFloorSeconds = minInterval;
+                           readParams.mMinIntervalFloorSeconds = 0;
                            // Select a max interval based on the device's claimed idle sleep interval.
                            auto idleSleepInterval = std::chrono::duration_cast<System::Clock::Seconds32>(
                                session.Value()->GetRemoteMRPConfig().mIdleRetransTimeout);
@@ -322,7 +322,7 @@ - (void)subscribeWithMinInterval:(uint16_t)minInterval
                            if (idleSleepInterval.count() > MTR_DEVICE_SUBSCRIPTION_MAX_INTERVAL_MAX) {
                                idleSleepInterval = System::Clock::Seconds32(MTR_DEVICE_SUBSCRIPTION_MAX_INTERVAL_MAX);
                            }
-                           readParams.mMaxIntervalCeilingSeconds = idleSleepInterval.count();
+                           readParams.mMaxIntervalCeilingSeconds = static_cast<uint16_t>(idleSleepInterval.count());
 
                            readParams.mpAttributePathParamsList = attributePath.get();
                            readParams.mAttributePathParamsListSize = 1;