Skip to content

Commit

Permalink
Reclassify excessive logging in LevelControl and OnOffServer from Pro…
Browse files Browse the repository at this point in the history
…gress to Detail (#27938)
  • Loading branch information
milanr-q authored and pull[bot] committed Jan 25, 2024
1 parent c9368a6 commit a687612
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/app/clusters/level-control/level-control.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ void emberAfLevelControlClusterServerTickCallback(EndpointId endpoint)
return;
}

ChipLogProgress(Zcl, "Event: move from %d", currentLevel.Value());
ChipLogDetail(Zcl, "Event: move from %d", currentLevel.Value());

// adjust by the proper amount, either up or down
if (state->transitionTimeMs == 0)
Expand All @@ -267,8 +267,8 @@ void emberAfLevelControlClusterServerTickCallback(EndpointId endpoint)
currentLevel.SetNonNull(static_cast<uint8_t>(currentLevel.Value() - 1));
}

ChipLogProgress(Zcl, " to %d ", currentLevel.Value());
ChipLogProgress(Zcl, "(diff %c1)", state->increasing ? '+' : '-');
ChipLogDetail(Zcl, " to %d ", currentLevel.Value());
ChipLogDetail(Zcl, "(diff %c1)", state->increasing ? '+' : '-');

status = Attributes::CurrentLevel::Set(endpoint, currentLevel);
if (status != EMBER_ZCL_STATUS_SUCCESS)
Expand Down
8 changes: 4 additions & 4 deletions src/app/clusters/on-off-server/on-off-server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ bool OnOffServer::OnWithTimedOffCommand(app::CommandHandler * commandObj, const
*/
void OnOffServer::updateOnOffTimeCommand(chip::EndpointId endpoint)
{
ChipLogProgress(Zcl, "Timer callback - Entering callbackc");
ChipLogDetail(Zcl, "Timer callback - Entering callback");

bool isOn = false;
OnOff::Attributes::OnOff::Get(endpoint, &isOn);
Expand All @@ -826,7 +826,7 @@ void OnOffServer::updateOnOffTimeCommand(chip::EndpointId endpoint)
// Update onTime values
uint16_t onTime = MIN_TIME_VALUE;
OnOff::Attributes::OnTime::Get(endpoint, &onTime);
ChipLogProgress(Zcl, "Timer callback - On Time: %d", onTime);
ChipLogDetail(Zcl, "Timer callback - On Time: %d", onTime);

if (onTime > 0)
{
Expand All @@ -836,7 +836,7 @@ void OnOffServer::updateOnOffTimeCommand(chip::EndpointId endpoint)

if (onTime == 0)
{
ChipLogProgress(Zcl, "Timer callback - Turning off OnOff");
ChipLogDetail(Zcl, "Timer callback - Turning off OnOff");

OnOff::Attributes::OffWaitTime::Set(endpoint, 0);
setOnOffValue(endpoint, Commands::Off::Id, false);
Expand All @@ -854,7 +854,7 @@ void OnOffServer::updateOnOffTimeCommand(chip::EndpointId endpoint)
OnOff::Attributes::OffWaitTime::Set(endpoint, offWaitTime);
}

ChipLogProgress(Zcl, "Timer Callback - wait Off Time: %d", offWaitTime);
ChipLogDetail(Zcl, "Timer Callback - wait Off Time: %d", offWaitTime);

// Validate if necessary to restart timer
if (offWaitTime > 0)
Expand Down

0 comments on commit a687612

Please sign in to comment.