Skip to content

Commit

Permalink
Fix dynamic bridge compile warnings from gcc (#23014)
Browse files Browse the repository at this point in the history
* Fix invalid compare in bridge example

* Fix dynamic bridge compiler warnings

* Undo submodule update
  • Loading branch information
andy31415 authored and pull[bot] committed Sep 14, 2023
1 parent 64fe822 commit 9dbc104
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ struct IsOptionalOrNullable<Nullable<X>>
static constexpr bool value = true;
};

static_assert(IsList<std::vector<unsigned char>>::value);
static_assert(IsList<std::vector<unsigned char>>::value, "Vector of chars must be a list");

template <typename X,
std::enable_if_t<!IsOptionalOrNullable<std::decay_t<X>>::value && !IsList<std::decay_t<X>>::value, bool> = true>
Expand Down Expand Up @@ -180,7 +180,7 @@ CHIP_ERROR Decode(const ConcreteDataAttributePath & aPath, AttributeValueDecoder
{
Span<std::decay_t<typename X::pointer>> span;
CHIP_ERROR err = aDecoder.Decode(span);
if (err = CHIP_NO_ERROR)
if (err == CHIP_NO_ERROR)
{
x = X(span.data(), span.size());
}
Expand Down

0 comments on commit 9dbc104

Please sign in to comment.