Fixed the crash due to packet buffers running out of space in Command…

…HandlerImpl. (#35279) * Fixed the crash due to packet buffers running out of space in CommandHandlerImpl * Update src/app/CommandHandlerImpl.h Co-authored-by: Terence Hampson <[email protected]> --------- Co-authored-by: Terence Hampson <[email protected]>
project-chip · Aug 29, 2024 · 9c59899 · 9c59899
1 parent 95ee157
commit 9c59899
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/app/CommandHandlerImpl.h b/src/app/CommandHandlerImpl.h
@@ -294,7 +294,12 @@ class CommandHandlerImpl : public CommandHandler
         {
             return CHIP_NO_ERROR;
         }
-        ReturnErrorOnFailure(RollbackResponse());
+        // The error value of RollbackResponse is not important if it fails, we prioritize
+        // conveying the error generated by addResponseFunction to the caller.
+        if (RollbackResponse() != CHIP_NO_ERROR)
+        {
+            return err;
+        }
         // If we failed to add a command due to lack of space in the
         // packet, we will make another attempt to add the response using
         // an additional InvokeResponseMessage.