Skip to content

Commit

Permalink
Tweaks from revivew
Browse files Browse the repository at this point in the history
  • Loading branch information
ksperling-apple committed Nov 28, 2023
1 parent 2e7ca25 commit 990d4ef
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions src/app/util/mock/MockNodeConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,6 @@
* limitations under the License.
*/

/**
* @file
* Helpers for configuring the mocked attribute-storage.cpp
*/

#pragma once

#include <app/util/af-types.h>
Expand Down
2 changes: 1 addition & 1 deletion src/app/util/mock/attribute-storage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ bool emberAfContainsServerFromIndex(uint16_t index, ClusterId clusterId)
{
auto config = GetMockNodeConfig();
VerifyOrReturnValue(index < config.endpoints.size(), false);
return true; // TODO: TestSceneTable relies on returning true here, we should fix (or use a dedicated) mock config instead
return true; // TODO: TestSceneTable relies on returning true here: https://github.com/project-chip/connectedhomeip/issues/30696
// return config.endpoints[index].clusterById(clusterId) != nullptr;
}

Expand Down

0 comments on commit 990d4ef

Please sign in to comment.