Skip to content

Commit

Permalink
Disable async DNS when use_dispatch is enabled. (#10060)
Browse files Browse the repository at this point in the history
In the use_dispatch setup the Matter stack is expected to not spin up
threads manually, but our async DNS implementation does just that via
pthreads.  This is leading to random failures in TestInetEndpoint on
Darwin due to thread data races.

Fixes #10025
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Oct 4, 2021
1 parent 479efc6 commit 9314481
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/inet/inet.gni
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,6 @@ declare_args() {
declare_args() {
# Enable async DNS.
chip_inet_config_enable_async_dns_sockets =
chip_inet_config_enable_dns_resolver && chip_system_config_use_sockets
chip_inet_config_enable_dns_resolver && chip_system_config_use_sockets &&
!chip_system_config_use_dispatch
}

0 comments on commit 9314481

Please sign in to comment.