Skip to content

Commit

Permalink
ESP32: remove the nogncheck in platform source (#37131)
Browse files Browse the repository at this point in the history
* ESP32: remove the nogncheck in platform source

* remove the workaround changes in ESP32 platform
  • Loading branch information
wqx6 authored Jan 21, 2025
1 parent 8ffb7b1 commit 84399bd
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
7 changes: 0 additions & 7 deletions src/platform/ESP32/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,6 @@ static_library("ESP32") {
"NetworkCommissioningDriver.cpp",
"NetworkCommissioningDriver.h",
]

# TODO: this is NOT ok, however we added a layering dependecy
# in NetworkCommissioningDriver accessing app/InteractionModelEngine.h
#
# Should be removed after https://github.com/project-chip/connectedhomeip/issues/37126
# is fixed
deps += [ "${chip_root}/src/access:access_config" ]
}

if (chip_mdns == "platform") {
Expand Down
4 changes: 0 additions & 4 deletions src/platform/ESP32/NetworkCommissioningDriver.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
* limitations under the License.
*/

#include <app/InteractionModelEngine.h> // nogncheck
#include <lib/support/CodeUtils.h>
#include <lib/support/SafeInt.h>
#include <platform/CHIPDeviceLayer.h>
Expand Down Expand Up @@ -459,9 +458,6 @@ void ESPWiFiDriver::OnScanWiFiNetworkDone()

void ESPWiFiDriver::OnNetworkStatusChange()
{
// This function reports the status to the data model provider, so skip it if the provider is not ready.
VerifyOrReturn(app::InteractionModelEngine::GetInstance() &&
app::InteractionModelEngine::GetInstance()->GetDataModelProvider());
Network configuredNetwork;
bool staEnabled = false, staConnected = false;
VerifyOrReturn(ESP32Utils::IsStationEnabled(staEnabled) == CHIP_NO_ERROR);
Expand Down

0 comments on commit 84399bd

Please sign in to comment.