Skip to content

Commit

Permalink
Make matter IDL generate more cases where attributes have default val…
Browse files Browse the repository at this point in the history 
…ues (#25948)

* Set default value in IDL for nullable defaults even if they are zero

* Regen all

* Even looser default value config for IDLs

* Regen all

* Regen all

* Zap regen - ran from vscode image this time

* Update helper back to use_cluster_attributes

* Add back the if included logic
  • Loading branch information
@andy31415 @pull
andy31415 authored and pull[bot] committed Oct 5, 2023
1 parent 5d419d5 commit 79f1757
Show file tree
Hide file tree
Showing 50 changed files with 4,170 additions and 4,170 deletions.
574 changes: 287 additions & 287 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
View file

Large diffs are not rendered by default.

362 changes: 181 additions & 181 deletions examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter
View file

Large diffs are not rendered by default.

230 changes: 115 additions & 115 deletions examples/bridge-app/bridge-common/bridge-app.matter
View file

Large diffs are not rendered by default.

266 changes: 133 additions & 133 deletions examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.matter
View file

Large diffs are not rendered by default.

92 changes: 46 additions & 46 deletions examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1457,7 +1457,7 @@ endpoint 0 {

server cluster Groups {
ram attribute nameSupport;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 3;
}

Expand All @@ -1466,7 +1466,7 @@ endpoint 0 {
callback attribute serverList;
callback attribute clientList;
callback attribute partsList;
ram attribute featureMap;
ram attribute featureMap default = 0;
callback attribute clusterRevision default = 1;
}

Expand All @@ -1479,7 +1479,7 @@ endpoint 0 {
callback attribute targetsPerAccessControlEntry;
callback attribute accessControlEntriesPerFabric;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}

Expand All @@ -1494,20 +1494,20 @@ endpoint 0 {
callback attribute productID;
persist attribute nodeLabel;
callback attribute location default = "XX";
callback attribute hardwareVersion;
callback attribute hardwareVersion default = 0;
callback attribute hardwareVersionString;
callback attribute softwareVersion;
callback attribute softwareVersion default = 0;
callback attribute softwareVersionString;
callback attribute manufacturingDate default = "20210614123456ZZ";
callback attribute partNumber;
callback attribute productURL;
callback attribute productLabel;
callback attribute serialNumber;
persist attribute localConfigDisabled;
persist attribute localConfigDisabled default = 0;
ram attribute reachable default = 1;
callback attribute uniqueID;
callback attribute capabilityMinima;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}

Expand All @@ -1517,17 +1517,17 @@ endpoint 0 {
emits event DownloadError;
callback attribute defaultOTAProviders;
ram attribute updatePossible default = 1;
ram attribute updateState;
ram attribute updateStateProgress;
ram attribute featureMap;
ram attribute updateState default = 0;
ram attribute updateStateProgress default = 0;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}

server cluster GeneralCommissioning {
ram attribute breadcrumb;
ram attribute breadcrumb default = 0x0000000000000000;
callback attribute basicCommissioningInfo;
callback attribute regulatoryConfig;
callback attribute locationCapability;
callback attribute regulatoryConfig default = 0;
callback attribute locationCapability default = 0;
callback attribute supportsConcurrentConnection default = 1;
ram attribute featureMap default = 6;
ram attribute clusterRevision default = 0x0001;
Expand All @@ -1547,39 +1547,39 @@ endpoint 0 {
}

server cluster DiagnosticLogs {
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}

server cluster GeneralDiagnostics {
emits event BootReason;
callback attribute networkInterfaces;
callback attribute rebootCount;
callback attribute upTime;
callback attribute totalOperationalHours;
callback attribute rebootCount default = 0x0000;
callback attribute upTime default = 0x0000000000000000;
callback attribute totalOperationalHours default = 0x00000000;
callback attribute bootReason;
callback attribute activeHardwareFaults;
callback attribute activeRadioFaults;
callback attribute activeNetworkFaults;
callback attribute testEventTriggersEnabled;
ram attribute featureMap;
callback attribute testEventTriggersEnabled default = false;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 0x0001;
}

server cluster SoftwareDiagnostics {
callback attribute threadMetrics;
callback attribute currentHeapFree;
callback attribute currentHeapUsed;
callback attribute currentHeapHighWatermark;
callback attribute currentHeapFree default = 0x0000000000000000;
callback attribute currentHeapUsed default = 0x0000000000000000;
callback attribute currentHeapHighWatermark default = 0x0000000000000000;
ram attribute featureMap default = 1;
ram attribute clusterRevision default = 0x0001;
}

server cluster AdministratorCommissioning {
callback attribute windowStatus;
callback attribute windowStatus default = 0;
callback attribute adminFabricIndex default = 1;
callback attribute adminVendorId;
ram attribute featureMap;
callback attribute adminVendorId default = 0;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 0x0001;
}

Expand All @@ -1590,7 +1590,7 @@ endpoint 0 {
callback attribute commissionedFabrics;
callback attribute trustedRootCertificates;
callback attribute currentFabricIndex;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 0x0001;
}

Expand All @@ -1599,20 +1599,20 @@ endpoint 0 {
callback attribute groupTable;
callback attribute maxGroupsPerFabric;
callback attribute maxGroupKeysPerFabric;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}
}
endpoint 1 {
device type anonymousEndpointType = 268, version 1;

server cluster Identify {
ram attribute identifyTime;
ram attribute identifyType;
ram attribute identifyTime default = 0x0;
ram attribute identifyType default = 0x0;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 4;
}

Expand All @@ -1621,33 +1621,33 @@ endpoint 1 {
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 3;
}

server cluster OnOff {
ram attribute onOff;
ram attribute onOff default = 0;
ram attribute globalSceneControl default = 1;
ram attribute onTime;
ram attribute offWaitTime;
ram attribute onTime default = 0;
ram attribute offWaitTime default = 0;
ram attribute startUpOnOff;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 4;
}

server cluster LevelControl {
ram attribute currentLevel;
ram attribute remainingTime;
ram attribute options;
ram attribute currentLevel default = 0x00;
ram attribute remainingTime default = 0x0000;
ram attribute options default = 0x00;
ram attribute onLevel;
ram attribute startUpCurrentLevel;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 5;
}

Expand All @@ -1659,15 +1659,15 @@ endpoint 1 {
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 1;
}

server cluster ColorControl {
ram attribute remainingTime;
ram attribute remainingTime default = 0x0000;
ram attribute colorTemperatureMireds default = 0x00FA;
ram attribute colorMode default = 0x01;
ram attribute options;
ram attribute options default = 0x00;
ram attribute numberOfPrimaries;
ram attribute primary1X;
ram attribute primary1Y;
Expand All @@ -1687,17 +1687,17 @@ endpoint 1 {
ram attribute primary6X;
ram attribute primary6Y;
ram attribute primary6Intensity;
ram attribute enhancedCurrentHue;
ram attribute enhancedCurrentHue default = 0x0000;
ram attribute enhancedColorMode default = 0x01;
ram attribute colorCapabilities;
ram attribute colorTempPhysicalMinMireds;
ram attribute colorCapabilities default = 0x0000;
ram attribute colorTempPhysicalMinMireds default = 0x0000;
ram attribute colorTempPhysicalMaxMireds default = 0xFEFF;
ram attribute coupleColorTempToLevelMinMireds;
ram attribute startUpColorTemperatureMireds;
callback attribute generatedCommandList;
callback attribute acceptedCommandList;
callback attribute attributeList;
ram attribute featureMap;
ram attribute featureMap default = 0;
ram attribute clusterRevision default = 5;
}
}
Expand Down
Loading

0 comments on commit 79f1757

Please sign in to comment.