Skip to content

Commit

Permalink
rename test to TC-SC-7.1
Browse files Browse the repository at this point in the history
TC-SC-5.1 exists, it's just in a different section.
  • Loading branch information
cecille committed Jul 20, 2024
1 parent a7cd91d commit 6bf8c61
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ jobs:
scripts/run_in_python_env.sh out/venv './scripts/tests/run_python_test.py --load-from-env /tmp/test_env.yaml --script src/python_testing/TC_RVCOPSTATE_2_1.py'
scripts/run_in_python_env.sh out/venv './scripts/tests/run_python_test.py --load-from-env /tmp/test_env.yaml --script src/python_testing/TC_RVCOPSTATE_2_3.py'
scripts/run_in_python_env.sh out/venv './scripts/tests/run_python_test.py --load-from-env /tmp/test_env.yaml --script src/python_testing/TC_RVCOPSTATE_2_4.py'
scripts/run_in_python_env.sh out/venv './scripts/tests/run_python_test.py --load-from-env /tmp/test_env.yaml --script src/python_testing/TC_SC_5_1.py'
scripts/run_in_python_env.sh out/venv './scripts/tests/run_python_test.py --load-from-env /tmp/test_env.yaml --script src/python_testing/TC_SC_7_1.py'
scripts/run_in_python_env.sh out/venv './scripts/tests/run_python_test.py --script "src/python_testing/TestConformanceSupport.py" --script-args "--trace-to json:out/trace_data/test-{SCRIPT_BASE_NAME}.json --trace-to perfetto:out/trace_data/test-{SCRIPT_BASE_NAME}.perfetto"'
scripts/run_in_python_env.sh out/venv './scripts/tests/run_python_test.py --script "src/python_testing/TestMatterTestingSupport.py" --script-args "--trace-to json:out/trace_data/test-{SCRIPT_BASE_NAME}.json --trace-to perfetto:out/trace_data/test-{SCRIPT_BASE_NAME}.perfetto"'
scripts/run_in_python_env.sh out/venv './scripts/tests/run_python_test.py --script "src/python_testing/TestSpecParsingSupport.py" --script-args "--trace-to json:out/trace_data/test-{SCRIPT_BASE_NAME}.json --trace-to perfetto:out/trace_data/test-{SCRIPT_BASE_NAME}.perfetto"'
Expand All @@ -585,7 +585,7 @@ jobs:
scripts/run_in_python_env.sh out/venv 'python3 ./src/python_testing/TestIdChecks.py'
scripts/run_in_python_env.sh out/venv 'python3 ./src/python_testing/TestConformanceSupport.py'
scripts/run_in_python_env.sh out/venv 'python3 ./src/python_testing/test_testing/test_IDM_10_4.py'
scripts/run_in_python_env.sh out/venv 'python3 ./src/python_testing/test_testing/test_TC_SC_5_1.py'
scripts/run_in_python_env.sh out/venv 'python3 ./src/python_testing/test_testing/test_TC_SC_7_1.py'
- name: Uploading core files
uses: actions/upload-artifact@v4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
# === END CI TEST ARGUMENTS ===

# Note that in the CI we are using the post-cert test as we can only start one app from the current script.
# This should still be fine as this test has unit tests for other conditions. See test_TC_SC_5_1.py
# This should still be fine as this test has unit tests for other conditions. See test_TC_SC_7_1.py
import logging
from glob import glob
from pathlib import Path
Expand All @@ -44,8 +44,8 @@ def _trusted_root_test_step(dut_num: int) -> TestStep:
return TestStep(dut_num, read_trusted_roots_over_pase, "List should be empty as the DUT should be in factory reset ")


class TC_SC_5_1(MatterBaseTest):
''' TC-SC-5.1
class TC_SC_7_1(MatterBaseTest):
''' TC-SC-7.1
This test requires two instances of the DUT with the same PID/VID to confirm that the individual
devices are provisioned with different discriminators and PAKE salts in the same product line.
Expand All @@ -63,7 +63,7 @@ def setup_class(self):
def expected_number_of_DUTs(self) -> int:
return 1 if self.post_cert_test else 2

def steps_TC_SC_5_1(self):
def steps_TC_SC_7_1(self):
if self.post_cert_test:
return [_trusted_root_test_step(1),
TestStep(2, "TH extracts the discriminator from the provided setup code", "Ensure the code is not the default")]
Expand All @@ -75,7 +75,7 @@ def steps_TC_SC_5_1(self):
# TODO: Need a pics or something to limit this to devices that have a factory-provided matter setup code (as opposed to a field upgradable device / device with a custom commissioning where this test won't apply)

@async_test_body
async def test_TC_SC_5_1(self):
async def test_TC_SC_7_1(self):
# For now, this test is WAY easier if we just ask for the setup code instead of discriminator / passcode
asserts.assert_false(self.matter_test_config.discriminators,
"This test needs to be run with either the QR or manual setup code. The QR code is preferred.")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def main():
manual_3333_20202021 = '31693312339'
manual_2222_20202024 = '20055212333'

test_runner = MockTestRunner('TC_SC_5_1', 'TC_SC_5_1', 'test_TC_SC_5_1', 0)
test_runner = MockTestRunner('TC_SC_7_1', 'TC_SC_7_1', 'test_TC_SC_7_1', 0)
failures = []

# Tests with no code specified should fail
Expand Down Expand Up @@ -157,7 +157,7 @@ def main():

test_runner.Shutdown()
print(
f"Test of TC-SC-5.1: test response incorrect: {len(failures)}")
f"Test of TC-SC-7.1: test response incorrect: {len(failures)}")
for f in failures:
print(f)

Expand Down

0 comments on commit 6bf8c61

Please sign in to comment.