Add to flake8 in workflow and fix python files (#25283)

project-chip · Aug 29, 2023 · 4fb7071 · 4fb7071
1 parent d29dd4f
commit 4fb7071
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/.flake8 b/.flake8
@@ -12,7 +12,6 @@ exclude = third_party
           src/test_driver/mbed/*
           src/test_driver/linux-cirque/*
           src/test_driver/esp32/*
-          src/test_driver/efr32/*
           build/chip/java/tests/*
           build/chip/linux/*
           build/config/linux/*
@@ -28,7 +27,6 @@ exclude = third_party
           scripts/build/builders/android.py
           scripts/build/builders/bouffalolab.py
           scripts/build/builders/cc13x2x7_26x2x7.py
-          scripts/build/builders/efr32.py
           scripts/build/builders/esp32.py
           scripts/build/builders/genio.py
           scripts/build/builders/gn.py

diff --git a/scripts/build/builders/efr32.py b/scripts/build/builders/efr32.py
@@ -167,16 +167,16 @@ def __init__(self,
         if chip_build_libshell:
             self.extra_gn_options.append('chip_build_libshell=true')
 
-        if chip_logging == False:
+        if chip_logging is False:
             self.extra_gn_options.append('chip_logging=false')
 
-        if chip_openthread_ftd == False:
+        if chip_openthread_ftd is False:
             self.extra_gn_options.append('chip_openthread_ftd=false')
 
         if enable_heap_monitoring:
             self.extra_gn_options.append('enable_heap_monitoring=true')
 
-        if enable_openthread_cli == False:
+        if enable_openthread_cli is False:
             self.extra_gn_options.append('enable_openthread_cli=false')
 
         if show_qr_code:
@@ -208,7 +208,8 @@ def __init__(self,
 
         if enable_ot_coap_lib:
             self.extra_gn_options.append(
-                'use_silabs_thread_lib=true chip_openthread_target="../silabs:ot-efr32-cert" use_thread_coap_lib=true openthread_external_platform=""')
+                'use_silabs_thread_lib=true chip_openthread_target="../silabs:ot-efr32-cert" '
+                'use_thread_coap_lib=true openthread_external_platform=""')
 
         if not no_version:
             shortCommitSha = subprocess.check_output(

diff --git a/src/test_driver/efr32/py/nl_test_runner/nl_test_runner.py b/src/test_driver/efr32/py/nl_test_runner/nl_test_runner.py
@@ -90,7 +90,7 @@ def read(): return serial_device.read(8192)
 def runner(client) -> int:
     """ Run the tests"""
     def on_error_callback(call_object, error):
-        raise Exception("Error running test RPC: {}".format(status))
+        raise Exception("Error running test RPC: {}".format(error))
 
     rpc = client.client.channel(1).rpcs.chip.rpc.NlTest.Run
     invoke = rpc.invoke(rpc.request(), on_error=on_error_callback)