Skip to content

Commit

Permalink
Update ZAP to pick up reportability changes. (#13802)
Browse files Browse the repository at this point in the history
We can now explicitly default all attributes to "reportable".  XML
files will be able to set reportingPolicy="prohibited" for things that
the Matter spec decides are not subscribable.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Jan 29, 2024
1 parent dafca69 commit 4916979
Show file tree
Hide file tree
Showing 7 changed files with 72 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/app/zap-templates/zcl/zcl.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,5 @@
"commandDiscovery": true
}
},
"defaultReportable": true
"defaultReportingPolicy": "mandatory"
}
2 changes: 1 addition & 1 deletion src/controller/data_model/controller-clusters.matter
Original file line number Diff line number Diff line change
Expand Up @@ -2320,7 +2320,7 @@ client cluster OperationalCredentials = 62 {
CHAR_STRING<32> label = 5;
}

readonly nosubscribe attribute NOCStruct NOCs[] = 0;
readonly attribute NOCStruct NOCs[] = 0;
readonly attribute FabricDescriptor fabricsList[] = 1;
readonly attribute int8u supportedFabrics = 2;
readonly attribute int8u commissionedFabrics = 3;
Expand Down
1 change: 1 addition & 0 deletions src/controller/python/chip/clusters/CHIPClusters.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions src/darwin/Framework/CHIP/zap-generated/CHIPClustersObjc.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions src/darwin/Framework/CHIP/zap-generated/CHIPClustersObjc.mm

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 46 additions & 0 deletions zzz_generated/chip-tool/zap-generated/cluster/Commands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4916979

Please sign in to comment.