Add tests for unbolt feature (#26956)

project-chip · Sep 15, 2023 · 380eb6e · 380eb6e
1 parent 504bfb0
commit 380eb6e
Show file tree

Hide file tree

Showing 7 changed files with 367 additions and 238 deletions.
diff --git a/examples/lock-app/lock-common/lock-app.matter b/examples/lock-app/lock-common/lock-app.matter
@@ -2601,7 +2601,7 @@ endpoint 1 {
     ram      attribute userCodeTemporaryDisableTime default = 10;
     ram      attribute requirePINforRemoteOperation default = 0;
     ram      attribute featureMap default = 0x1DB3;
-    ram      attribute clusterRevision default = 6;
+    ram      attribute clusterRevision default = 7;
   }
 }
 

diff --git a/examples/lock-app/lock-common/lock-app.zap b/examples/lock-app/lock-common/lock-app.zap
@@ -7760,7 +7760,7 @@
               "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "6",
+              "defaultValue": "7",
               "reportable": 1,
               "minInterval": 0,
               "maxInterval": 65344,
@@ -7928,4 +7928,4 @@
       "deviceIdentifier": 10
     }
   ]
-}
+}
diff --git a/src/app/tests/suites/certification/PICS.yaml b/src/app/tests/suites/certification/PICS.yaml
@@ -2694,6 +2694,9 @@ PICS:
     - label: "Does the DUT(server) support the Clear Credential command?"
       id: DRLK.S.C26.Rsp
 
+    - label: "Does the DUT(server) support the Unbolt Door command?"
+      id: DRLK.S.C27.Rsp
+
     #
     # server / commandsGenerated
     #
@@ -2792,6 +2795,9 @@ PICS:
           schedules feature?"
       id: DRLK.S.F0b
 
+    - label: "Does the DUT(server) support the Lock supports unbolting feature?"
+      id: DRLK.S.F0c
+
     #
     # server / manually
     #
@@ -3068,6 +3074,9 @@ PICS:
     - label: "Does the DUT(Client) support the Clear Credential command?"
       id: DRLK.C.C26.Tx
 
+    - label: "Does the DUT(Client) support the Unbolt Door command?"
+      id: DRLK.C.C27.Tx
+
     #
     # client / Events
     #
@@ -3139,6 +3148,9 @@ PICS:
           schedules feature?"
       id: DRLK.C.F0b
 
+    - label: "Does the DUT(client) support the Lock supports unbolting feature?"
+      id: DRLK.C.F0c
+
     # Ethernet Network Diagnostics Cluster Test Plan
     - label:
           "Does the device implement the Ethernet Network Diagnostics cluster as

diff --git a/src/app/tests/suites/certification/Test_TC_DRLK_1_1.yaml b/src/app/tests/suites/certification/Test_TC_DRLK_1_1.yaml
@@ -36,15 +36,15 @@ tests:
       command: "readAttribute"
       attribute: "ClusterRevision"
       response:
-          value: 6
+          value: 7
           constraints:
               type: int16u
 
     - label: "TH reads the FeatureMap from DUT"
       PICS:
           " !DRLK.S.F00 && !DRLK.S.F01 && !DRLK.S.F02 && !DRLK.S.F04 &&
           !DRLK.S.F05 && !DRLK.S.F06 && !DRLK.S.F07 && !DRLK.S.F08 &&
-          !DRLK.S.F0a && !DRLK.S.F0b "
+          !DRLK.S.F0a && !DRLK.S.F0b && !DRLK.S.F0c "
       command: "readAttribute"
       attribute: "FeatureMap"
       response:
@@ -142,6 +142,15 @@ tests:
               type: bitmap32
               hasMasksSet: [0x800]
 
+    - label: "Given DRLK.S.F0c(UBOLT) ensure featuremap has the correct bit set"
+      PICS: DRLK.S.F0c
+      command: "readAttribute"
+      attribute: "FeatureMap"
+      response:
+          constraints:
+              type: bitmap32
+              hasMasksSet: [0x1000]
+
     - label: "TH reads AttributeList from DUT"
       command: "readAttribute"
       attribute: "AttributeList"
@@ -405,6 +414,17 @@ tests:
               type: list
               contains: [17, 18, 19]
 
+    - label:
+          "TH reads Feature dependent commands(DRLK.S.F0c) in
+          AcceptedCommandList"
+      PICS: DRLK.S.F0c
+      command: "readAttribute"
+      attribute: "AcceptedCommandList"
+      response:
+          constraints:
+              type: list
+              contains: [39]
+
     - label:
           "TH reads Feature dependent commands(DRLK.S.F08) in
           AcceptedCommandList"

diff --git a/src/app/tests/suites/certification/ci-pics-values b/src/app/tests/suites/certification/ci-pics-values
@@ -1470,6 +1470,7 @@ DRLK.S.A0035=1
 DRLK.C=1
 DRLK.C.F0a=0
 DRLK.C.F0b=0
+DRLK.C.F0c=0
 
 # Server Events
 DRLK.S.E00=1
@@ -1489,6 +1490,7 @@ DRLK.S.F07=1
 DRLK.S.F08=1
 DRLK.S.F0a=1
 DRLK.S.F0b=1
+DRLK.S.F0c=1
 
 # Server Commands
 DRLK.S.C00.Rsp=1
@@ -1509,6 +1511,7 @@ DRLK.S.C1d.Rsp=1
 DRLK.S.C22.Rsp=1
 DRLK.S.C24.Rsp=1
 DRLK.S.C26.Rsp=1
+DRLK.S.C27.Rsp=1
 DRLK.S.C0c.Tx=1
 DRLK.S.C0f.Tx=1
 DRLK.S.C12.Tx=1
@@ -1590,6 +1593,7 @@ DRLK.C.C1d.Tx=1
 DRLK.C.C22.Tx=1
 DRLK.C.C24.Tx=1
 DRLK.C.C26.Tx=1
+DRLK.C.C27.Tx=1
 DRLK.C.C0c.Rsp=1
 DRLK.C.C0f.Rsp=1
 DRLK.C.C12.Rsp=1