Enable -Wconversion tree-wide on darwin.

project-chip · Feb 28, 2023 · 34d7456 · 34d7456
1 parent 92d86d5
commit 34d7456
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
@@ -249,6 +249,10 @@ config("strict_warnings") {
     ]
   }
 
+  if (current_os == "mac" || current_os == "ios") {
+    cflags += [ "-Wconversion" ]
+  }
+
   if (build_java_matter_controller) {
     cflags -= [ "-Wshadow" ]
   }

diff --git a/third_party/boringssl/repo/BUILD.gn b/third_party/boringssl/repo/BUILD.gn
@@ -20,7 +20,10 @@ import("BUILD.generated.gni")
 config("boringssl_config") {
   include_dirs = [ "src/include" ]
 
-  cflags = [ "-Wno-unused-variable" ]
+  cflags = [
+    "-Wno-unused-variable",
+    "-Wno-conversion",
+  ]
 
   if (is_clang) {
     cflags += [ "-Wno-shorten-64-to-32" ]

diff --git a/third_party/editline/BUILD.gn b/third_party/editline/BUILD.gn
@@ -18,8 +18,10 @@ import("${build_root}/config/compiler/compiler.gni")
 config("editline_config") {
   include_dirs = [ "repo/include" ]
 
+  cflags = [ "-Wno-conversion" ]
+
   if (is_clang) {
-    cflags = [ "-Wno-shorten-64-to-32" ]
+    cflags += [ "-Wno-shorten-64-to-32" ]
   }
 }
 

diff --git a/third_party/nlunit-test/BUILD.gn b/third_party/nlunit-test/BUILD.gn
@@ -18,8 +18,10 @@ import("${build_root}/config/compiler/compiler.gni")
 config("nlunit-test_config") {
   include_dirs = [ "repo/src" ]
 
+  cflags = [ "-Wno-conversion" ]
+
   if (is_clang) {
-    cflags = [ "-Wno-shorten-64-to-32" ]
+    cflags += [ "-Wno-shorten-64-to-32" ]
   }
 }