Skip to content

Commit

Permalink
Temp fix for #32875 (network commissioning cluster check for SSID on …
Browse files Browse the repository at this point in the history
…Thread feature) (#32884)

* Temp fix for 32875

* Clarify comments
  • Loading branch information
chrisdecenzo authored and pull[bot] committed Aug 4, 2024
1 parent 695eaf0 commit 3335625
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions src/app/clusters/network-commissioning/network-commissioning.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -491,12 +491,17 @@ void Instance::HandleScanNetworks(HandlerContext & ctx, const Commands::ScanNetw
}
else if (mFeatureFlags.Has(Feature::kThreadNetworkInterface))
{
// NOTE: the following lines were commented out due to issue #32875. In short, a popular
// commissioner is passing a null SSID argument and this logic breaks interoperability as a result.
// The spec has some inconsistency on this which also needs to be fixed. The commissioner maker is
// fixing its code and will return to un-comment this code, with that work tracked by Issue #32887.
//
// SSID present on Thread violates the `[WI]` conformance.
if (req.ssid.HasValue())
{
ctx.mCommandHandler.AddStatus(ctx.mRequestPath, Protocols::InteractionModel::Status::InvalidCommand);
return;
}
// if (req.ssid.HasValue())
// {
// ctx.mCommandHandler.AddStatus(ctx.mRequestPath, Protocols::InteractionModel::Status::InvalidCommand);
// return;
// }

mCurrentOperationBreadcrumb = req.breadcrumb;
mAsyncCommandHandle = CommandHandler::Handle(&ctx.mCommandHandler);
Expand Down

0 comments on commit 3335625

Please sign in to comment.