Skip to content

Commit

Permalink
[nrfconnect] Bring back BLE write requests (#7039)
Browse files Browse the repository at this point in the history
PR #6955, apart from changing from BLE indications to
notifications on nRF Connect platform, started require
controllers to use WriteCommon (aka Write without response)
only as that is required by the spec.

However, Darwin platform layer still uses WriteRequest
(aka Write with response) method, so the change broke
compatibility between mac and nRF Connect platforms.

Support both methods on the firmware side.
  • Loading branch information
Damian-Nordic authored and pull[bot] committed Jun 21, 2021
1 parent dd09b7e commit 1035200
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/platform/Zephyr/BLEManagerImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ _bt_gatt_ccc CHIPoBLEChar_TX_CCC = BT_GATT_CCC_INITIALIZER(nullptr, BLEManagerIm
BT_GATT_SERVICE_DEFINE(CHIPoBLE_Service,
BT_GATT_PRIMARY_SERVICE(&UUID16_CHIPoBLEService.uuid),
BT_GATT_CHARACTERISTIC(&UUID128_CHIPoBLEChar_RX.uuid,
BT_GATT_CHRC_WRITE_WITHOUT_RESP,
BT_GATT_CHRC_WRITE | BT_GATT_CHRC_WRITE_WITHOUT_RESP,
BT_GATT_PERM_READ | BT_GATT_PERM_WRITE,
nullptr, BLEManagerImpl::HandleRXWrite, nullptr),
BT_GATT_CHARACTERISTIC(&UUID128_CHIPoBLEChar_TX.uuid,
Expand Down

0 comments on commit 1035200

Please sign in to comment.