Defined a constant for default delayedActionTime

project-chip · Jan 21, 2022 · 01fa17d · 01fa17d
1 parent 4f66507
commit 01fa17d
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/src/platform/GenericOTARequestorDriver.cpp b/src/platform/GenericOTARequestorDriver.cpp
@@ -32,6 +32,8 @@ GenericOTARequestorDriver * ToDriver(void * context)
     return static_cast<GenericOTARequestorDriver *>(context);
 }
 
+constexpr System::Clock::Seconds32 kDefaultDelayedActionTime = System::Clock::Seconds32(120);
+
 } // namespace
 
 bool GenericOTARequestorDriver::CanConsent()
@@ -60,13 +62,12 @@ void GenericOTARequestorDriver::UpdateNotFound(UpdateNotFoundReason reason, Syst
 {
     VerifyOrDie(mRequestor != nullptr);
 
-    System::Clock::Seconds32 delayedActionTime = System::Clock::Seconds32(120);
-    if (delay > delayedActionTime)
+    if (delay < kDefaultDelayedActionTime)
     {
-        delayedActionTime = delay;
+        delay = kDefaultDelayedActionTime;
     }
 
-    ScheduleDelayedAction(UpdateFailureState::kQuerying, delayedActionTime,
+    ScheduleDelayedAction(UpdateFailureState::kQuerying, delay,
                           [](System::Layer *, void * context) { ToDriver(context)->mRequestor->TriggerImmediateQuery(); });
 }
 
@@ -87,13 +88,12 @@ void GenericOTARequestorDriver::UpdateSuspended(System::Clock::Seconds32 delay)
 {
     VerifyOrDie(mRequestor != nullptr);
 
-    System::Clock::Seconds32 delayedActionTime = System::Clock::Seconds32(120);
-    if (delay > delayedActionTime)
+    if (delay < kDefaultDelayedActionTime)
     {
-        delayedActionTime = delay;
+        delay = kDefaultDelayedActionTime;
     }
 
-    ScheduleDelayedAction(UpdateFailureState::kAwaitingNextAction, delayedActionTime,
+    ScheduleDelayedAction(UpdateFailureState::kAwaitingNextAction, delay,
                           [](System::Layer *, void * context) { ToDriver(context)->mRequestor->ApplyUpdate(); });
 }