Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix brokerJob specs to use imagePullPolicy and image tag from values.yaml #715

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix brokerJob specs to use imagePullPolicy and image tag from values.yaml #715

merged 1 commit into from
Nov 5, 2024

Conversation

melinda-mytra
Copy link
Contributor

@melinda-mytra melinda-mytra commented Nov 4, 2024 •
edited
Loading

What this PR does / why we need it:
Updates the three brokerJob specs to correctly use the pullPolicy and image tag from the corresponding brokerJob section of values.yaml

closes #713
closes #712

Special notes for your reviewer:

If applicable:

  • [n/a] this PR has an associated PR with documentation in akri-docs
  • [n/a ] this PR contains unit tests
  • [n/a] added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@melinda-mytra melinda-mytra changed the title fix brokerJob spec to use imagePullPolicy and image tag from values.yaml fix brokerJob specs to use imagePullPolicy and image tag from values.yaml Nov 4, 2024
kate-goldenring
kate-goldenring approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @melinda-mytra

@kate-goldenring
Copy link
Contributor

@diconico07 looks like for our K8s tests there are some SUSE related signatures out of date. Would you be able to take a look?

@kate-goldenring
Copy link
Contributor

Looks like we need to bump our kubernetes versions. the ones we are using reached EOL: https://endoflife.date/kubernetes

@kate-goldenring
Copy link
Contributor

I am going to merge this and we can fix CI in #716

@kate-goldenring kate-goldenring merged commit 409d78d into project-akri:main Nov 5, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-goldenring kate-goldenring kate-goldenring approved these changes

@bfjelds bfjelds Awaiting requested review from bfjelds bfjelds is a code owner

@jiria jiria Awaiting requested review from jiria jiria is a code owner

@Britel Britel Awaiting requested review from Britel Britel is a code owner

@romoh romoh Awaiting requested review from romoh romoh is a code owner

@adithyaj adithyaj Awaiting requested review from adithyaj adithyaj is a code owner

@johnsonshih johnsonshih Awaiting requested review from johnsonshih johnsonshih is a code owner

@diconico07 diconico07 Awaiting requested review from diconico07 diconico07 is a code owner

Assignees
No one assigned
Labels
same version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pullPolicy for brokerJob fetched from wrong section of values.yaml brokerJob uses brokerPod image tag
2 participants
@melinda-mytra @kate-goldenring